-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent panic in Org mode HighlightCodeBlock #17140
Merged
zeripath
merged 3 commits into
go-gitea:main
from
zeripath:fix-17139-prevent-panic-in-org-mode
Sep 24, 2021
Merged
Prevent panic in Org mode HighlightCodeBlock #17140
zeripath
merged 3 commits into
go-gitea:main
from
zeripath:fix-17139-prevent-panic-in-org-mode
Sep 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rendering source in org mode there is a mistake in the highlight code that causes a panic. This PR fixes this. Fix go-gitea#17139 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Sep 24, 2021
Backport go-gitea#17140 When rendering source in org mode there is a mistake in the highlight code that causes a panic. This PR fixes this. Fix go-gitea#17139 Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny
approved these changes
Sep 24, 2021
wxiaoguang
reviewed
Sep 24, 2021
axifive
approved these changes
Sep 24, 2021
zeripath
commented
Sep 24, 2021
make lgtm work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering source in org mode there is a mistake in the highlight code that
causes a panic.
This PR fixes this.
Fix #17139
Signed-off-by: Andrew Thornton art27@cantab.net