Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve checkBranchName #17901

Merged
merged 13 commits into from
Dec 8, 2021
Merged

Improve checkBranchName #17901

merged 13 commits into from
Dec 8, 2021

Commits on Dec 3, 2021

  1. Improve checkBranchName 

    The current implementation of checkBranchName is highly inefficient
involving opening the repository, the listing all of the branch names
checking them individually before then using using opened repo to get
the tags.

This PR avoids this by simply walking the references from show-ref
instead of opening the repository (in the nogogit case).

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    0ec78a8 View commit details
    Browse the repository at this point in the history

  2. oops 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    54d1a86 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into improve-checkbranchname

    @zeripath
    zeripath committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    92c8e4e View commit details
    Browse the repository at this point in the history

  4. fix tests 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    9d2b525 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2021

  1. fix tests again 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    b15af7f View commit details
    Browse the repository at this point in the history

  2. Use the common ctx.Repo.Gitrepo instead of reopening it for loadBranches

    @zeripath
    zeripath committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    131285c View commit details
    Browse the repository at this point in the history

  3. another fixup 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    1c1312d View commit details
    Browse the repository at this point in the history

  4. placate lint 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    7b459b7 View commit details
    Browse the repository at this point in the history

  5. placate lint2 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    4ed5af2 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. Merge branch 'main' into improve-checkbranchname

    @lunny
    lunny committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    ca8b4ea View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into improve-checkbranchname

    @wxiaoguang
    wxiaoguang committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    6981358 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into improve-checkbranchname

    @zeripath
    zeripath committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    8fa3849 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into improve-checkbranchname

    @lunny
    lunny committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    ebec87a View commit details
    Browse the repository at this point in the history