Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix expired testing key #17984

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Fix expired testing key #17984

merged 1 commit into from
Dec 14, 2021

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Dec 14, 2021

Currently testing fails because the testing key expired some hours ago.
This PR replaced the key with a non-expiring key.

gpg --full-gen-key

kind: (1) RSA and RSA (default)
key size: 3072
valid for: 0 = key does not expire
real name: gitea
email address: gitea@fake.local
no passphrases

gpg --output private-testing.key --armor --export-secret-key gitea@fake.local

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 14, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #17984 (2a528f6) into main (0981ec3) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17984   +/-   ##
=======================================
  Coverage   45.27%   45.28%           
=======================================
  Files         820      820           
  Lines       90933    90933           
=======================================
+ Hits        41172    41175    +3     
+ Misses      43204    43198    -6     
- Partials     6557     6560    +3
Impacted Files Coverage Δ
modules/git/utils.go 68.05% <0.00%> (-2.78%) ⬇️
models/unit/unit.go 41.09% <0.00%> (-2.74%) ⬇️
modules/git/repo_base_nogogit.go 84.21% <0.00%> (-2.64%) ⬇️
models/asymkey/gpg_key_commit_verification.go 44.16% <0.00%> (-2.13%) ⬇️
models/issue_comment.go 52.47% <0.00%> (-0.57%) ⬇️
routers/web/repo/view.go 39.58% <0.00%> (-0.48%) ⬇️
services/pull/pull.go 41.78% <0.00%> (-0.41%) ⬇️
modules/queue/queue_bytefifo.go 59.88% <0.00%> (+0.59%) ⬆️
modules/queue/queue_disk_channel.go 62.72% <0.00%> (+1.77%) ⬆️
modules/queue/queue_channel.go 96.66% <0.00%> (+5.00%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0981ec3...2a528f6. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 14, 2021
@techknowlogick techknowlogick added this to the 1.16.0 milestone Dec 14, 2021
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 14, 2021
@techknowlogick techknowlogick merged commit bfe597c into go-gitea:main Dec 14, 2021
@techknowlogick
Copy link
Member

please send backport :)

KN4CK3R added a commit to KN4CK3R/gitea that referenced this pull request Dec 14, 2021
@KN4CK3R
Use non-expiring key. (go-gitea#17984)
c226509
@KN4CK3R KN4CK3R mentioned this pull request Dec 14, 2021
Merged
techknowlogick pushed a commit that referenced this pull request Dec 14, 2021
@KN4CK3R
Use non-expiring key. (#17984) (#17985)
31df892
@silverwind silverwind mentioned this pull request Dec 15, 2021
Closed
Caellion added a commit to Caellion/gitea that referenced this pull request Dec 15, 2021
@Caellion @silverwind
Merge https://github.com/go-gitea/gitea into upstream-master
358ba98 
* https://github.com/go-gitea/gitea:
  [skip ci] Updated translations via Crowdin
  Use non-expiring key. (go-gitea#17984)

Co-Authored-By: silverwind <me@silverwind.io>
@KN4CK3R KN4CK3R deleted the fix-testing-key branch December 16, 2021 13:13
zeripath added a commit to zeripath/gitea that referenced this pull request Dec 19, 2021
@zeripath
Changelog 1.15.8
6b6e5a3 
 ## [1.15.8](https://github.com/go-gitea/gitea/releases/tag/v1.15.8) - 2021-12-19

* BUGFIXES
  * Reset locale on login (go-gitea#18023) (go-gitea#18025)
  * Fix reset password email template (go-gitea#17025) (go-gitea#18022)
  * Fix outType on gitea dump (go-gitea#18000) (go-gitea#18016)
  * Ensure complexity, minlength and isPwned are checked on password setting (go-gitea#18005) (go-gitea#18015)
  * Fix rename notification bug (go-gitea#18011)
  * Prevent double decoding of % in url params  (go-gitea#17997) (go-gitea#18001)
  * Prevent hang in git cat-file if the repository is not a valid repository (Partial go-gitea#17991) (go-gitea#17992)
  * Prevent deadlock in create issue (go-gitea#17970) (go-gitea#17982)
* TESTING
  * Use non-expiring key. (go-gitea#17984) (go-gitea#17985)

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Dec 19, 2021
Merged
lafriks pushed a commit that referenced this pull request Dec 20, 2021
@zeripath @6543
Changelog 1.15.8 (#18026)
6081948 
## [1.15.8](https://github.com/go-gitea/gitea/releases/tag/v1.15.8) - 2021-12-19

* BUGFIXES
  * Reset locale on login (#18023) (#18025)
  * Fix reset password email template (#17025) (#18022)
  * Fix outType on gitea dump (#18000) (#18016)
  * Ensure complexity, minlength and isPwned are checked on password setting (#18005) (#18015)
  * Fix rename notification bug (#18011)
  * Prevent double decoding of % in url params  (#17997) (#18001)
  * Prevent hang in git cat-file if the repository is not a valid repository (Partial #17991) (#17992)
  * Prevent deadlock in create issue (#17970) (#17982)
* TESTING
  * Use non-expiring key. (#17984) (#17985)

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Update CHANGELOG.md

Co-authored-by: 6543 <6543@obermui.de>
@zeripath zeripath added the backport/done All backports for this PR have been created label Dec 25, 2021
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@KN4CK3R
Use non-expiring key. (go-gitea#17984)
0ee689b
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@jpraet jpraet jpraet approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@KN4CK3R @codecov-commenter @techknowlogick @jpraet @zeripath @GiteaBot