Replace deprecated String.prototype.substr() with String.prototype.slice() #18796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
GiteaBot
added
the
lgtm/need 2
|
|
Codecov Report
@@ Coverage Diff @@
## main #18796 +/- ##
=======================================
Coverage ? 46.58%
=======================================
Files ? 853
Lines ? 122463
Branches ? 0
=======================================
Hits ? 57050
Misses ? 58526
Partials ? 6887 Continue to review full report at Codecov.
|
|
My apologies. I ignored the files in the vendor folder but didn't check if the other files are possibly vendored as well. I have now changed the commit to exclude the mentioned file |
…ice() String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with the slice() method which works similarily but isn't deprecated. Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
silverwind
approved these changes
Feb 17, 2022
GiteaBot
added
lgtm/need 1
Gusted
approved these changes
Feb 17, 2022
GiteaBot
added
lgtm/done
silverwind
added
the
type/refactoring
|
CI failure is unrelated, maybe #18793 will resolve it. |
|
make L-G-T-M work |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 18, 2022
* giteaofficial/main: Fix ldap loginname (go-gitea#18789) Replace deprecated String.prototype.substr() with String.prototype.slice() (go-gitea#18796) Fix problem when self-assign notification (go-gitea#18797) Move editorconfig-checker to lint-backend and remove JS wrapper (go-gitea#18793)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
…ice() (go-gitea#18796) String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with the slice() method which works similarily but isn't deprecated. Signed-off-by: Tobias Speicher <rootcommander@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String.prototype.substr() is deprecated so we replace it with the String.prototype.slice() method which works similarily but isn't deprecated.
substr() probably isn't going away anytime soon but it doesn't hurt to replace it as the change isn't difficult at all.