-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: update kevinburke/ssh_config to v1.2.0 #19286
Conversation
Previously if you tried to read a HostName in a config file that looked like this: ``` Host github HostName github.com # This is the host for code review ``` DefaultUserSettings.Get("HostName") would return "github.com ", which I think is unintuitive and unexpected. This behavior is fixed in v1.2 which would return "github.com" in the above example.
Hmm would be nice if go-git/go-git#507 was merged soon(so we can update go-git as a whole and don't update indirect dependencies ourselves). But seems to be rather non-breaking change, approving. |
Yeah, I'm submitting to most of the dependencies because I don't know if/when go-git will get updated. |
Their last update was nine updates ago and last activity was over a month so 🤷🏽. |
Codecov Report
@@ Coverage Diff @@
## main #19286 +/- ##
=======================================
Coverage ? 47.41%
=======================================
Files ? 939
Lines ? 131127
Branches ? 0
=======================================
Hits ? 62178
Misses ? 61471
Partials ? 7478 Continue to review full report at Codecov.
|
* giteaoffical/main: Fix broken of team create (go-gitea#19288) Remove `git.Command.Run` and `git.Command.RunInDir*` (go-gitea#19280) Performance improvement for add team user when org has more than 1000 repositories (go-gitea#19227) [skip ci] Updated translations via Crowdin Update JS dependencies (go-gitea#19281) Fix container download counter (go-gitea#19287) go.mod: update kevinburke/ssh_config to v1.2.0 (go-gitea#19286) Fix global packages enabled avaiable (go-gitea#19276) Add Goroutine stack inspector to admin/monitor (go-gitea#19207) Move checks for pulls before merge into own function (go-gitea#19271) Restore user autoregistration with email addresses (go-gitea#19261) Improve sync performance for pull-mirrors (go-gitea#19125) Refactor `git.Command.Run*`, introduce `RunWithContextString` and `RunWithContextBytes` (go-gitea#19266) Move reaction to models/issues/ (go-gitea#19264)
Previously if you tried to read a HostName in a config file that
looked like this:
DefaultUserSettings.Get("HostName") would return "github.com ",
which I think is unintuitive and unexpected.
This behavior is fixed in v1.2 which would return "github.com" in the
above example.