-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Federation: return useful statistic information for nodeinfo #19561
Conversation
@zeripath recently added caching to some of these stats, are you able to leverage the cache as well? |
@techknowlogick added cache |
This comment was marked as outdated.
This comment was marked as outdated.
The question again, why does Gitea need to provide the accurate count number instead of the estimated count number? I do not think it's worth introducing new setting options (#19474) to provide the accurate count number which is using slow full table (index) scan. In the other PR: there are options about estimated or not / cache TTL, already doubled to 4 new options, and in future maybe more 6, 8 options if more APIs are introduced .... Could the problem be simplified to: only provide estimated count number for all users/actions/issues, etc? From #19474:
|
What's the aim to expose these statistic information? |
so services likehttps://the-federation.info/ (https://github.com/thefederationinfo/the-federation.info/issues/149) can discover nodes and make suggestions where to join the "federated gitea network" |
@wxiaoguang @zeripath to the cache and aproximate counts: you can not count users aproximate, as orgs are also in the same table. beside the caching in #19474, I would like to implement it as router middleware later on (not part of this pull atm), so we can transparent say |
I still think we should add this, all federated software I know of has this flag/setting (synapse, diaspora, ...) |
nodeinfo is not for the admin but for the federation ... as per label |
The For this one, |
ok, is something else blocking it? |
Maybe we need a doc about federation which information will be exposed. |
@lunny I think we need a new document section for federation, since this is only one part we should explain & document should I add it in this pull? |
Co-authored-by: delvh <dev.lh@web.de>
-> Federation: return useful statistic information for nodeinfo |
* giteaofficial/main: Fix some slice problems (incorrect slice length) (go-gitea#19592) Fix sending empty notifications (go-gitea#19589) Handle the error of a missing blob object fix go-gitea#19530 (go-gitea#19552) Remove legacy `+build:` constraint (go-gitea#19582) Federation: return useful statistic information for nodeinfo (go-gitea#19561) Upgrade required git version to 2.0 (go-gitea#19577) add smtp password to install page (go-gitea#17564) ignore DNS error when doing migration allow/block check (go-gitea#19566) [skip ci] Updated translations via Crowdin Dont overwrite err with nil & rename PullCheckingFuncs to reflect there usage (go-gitea#19572) Improve UI on mobile (go-gitea#19546) Add API to check if team has repo access (go-gitea#19540)
…a#19561) Add statistic information for total user count, active user count, issue count and comment count for `/nodeinfo`
TODO: