Increase minimal required git version to 2.0 #19577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
type/refactoring
delvh
approved these changes
May 2, 2022
GiteaBot
added
the
lgtm/need 1
|
We need also update documentation. from-binary.en-us.md |
Where? I didn't see hard-coded git version in that document, and I think we shouldn't put hard-coded version into it either .... the error message is clear enough when gitea is running. |
|
Or do you mean to change the line from
to
?? |
|
I think there are more version checks we now can remove |
lunny
approved these changes
May 2, 2022
GiteaBot
added
lgtm/done
6543
approved these changes
May 2, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 3, 2022
* giteaofficial/main: Fix some slice problems (incorrect slice length) (go-gitea#19592) Fix sending empty notifications (go-gitea#19589) Handle the error of a missing blob object fix go-gitea#19530 (go-gitea#19552) Remove legacy `+build:` constraint (go-gitea#19582) Federation: return useful statistic information for nodeinfo (go-gitea#19561) Upgrade required git version to 2.0 (go-gitea#19577) add smtp password to install page (go-gitea#17564) ignore DNS error when doing migration allow/block check (go-gitea#19566) [skip ci] Updated translations via Crowdin Dont overwrite err with nil & rename PullCheckingFuncs to reflect there usage (go-gitea#19572) Improve UI on mobile (go-gitea#19546) Add API to check if team has repo access (go-gitea#19540)
This was referenced Jun 9, 2022
zeripath
changed the title
zeripath
changed the title
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
* Upgrade required git version to 2.0 * update document
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #19554
This PR only upgrades the
GitVersionRequiredvariable to2.0.0. All code for git 1.x are not changed, then if some users want to test with old git client or bypass the check, they still have a chance to edit the GitVersionRequired manually.Code for git 1.x could be removed in a separate PR before 1.17 frozen.
And since there are a lot of CentOS 7 users, a friendly hint is added to tell them how to install latest git client.
This PR makes Gitea require git >= 2.0, follow https://git-scm.com/download/ to install latest git client if your git is too old.