Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying SECRET_KEY_URI, similar to INTERNAL_TOKEN_URI #19663

Merged
merged 9 commits into from
Oct 1, 2022
Merged

Allow specifying SECRET_KEY_URI, similar to INTERNAL_TOKEN_URI #19663

merged 9 commits into from
Oct 1, 2022

Commits on Sep 11, 2022

  1. Allow specifying SECRET_KEY_URI, similar to INTERNAL_TOKEN_URI 

    This modifies the existing internal token loading and the new secret key loading such that:

* Specifying both INTERNAL_TOKEN and INTERNAL_TOKEN_URI is an error, instead of just preferring the URI
* The install lock isn't required to regenerate the internal token or the secret key; it will always be regenerated if it's absent
    @clarfonthey
    clarfonthey committed Sep 11, 2022
    Configuration menu
    Copy the full SHA
    620410c View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. make log clear when setting.CreateOrAppendToCustomConf

    @wxiaoguang
    wxiaoguang committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    5cbdab7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into secret_uris

    @wxiaoguang
    wxiaoguang committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    811d1de View commit details
    Browse the repository at this point in the history

  3. rename loadSecret to loadOrGenerateSecret and add more comments

    @wxiaoguang
    wxiaoguang committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    1119fee View commit details
    Browse the repository at this point in the history

  4. do not write the default secret to config (keep the old behavior)

    @wxiaoguang
    wxiaoguang committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    7b5140c View commit details
    Browse the repository at this point in the history

  5. fix document

    @wxiaoguang
    wxiaoguang committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    c2f0a01 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. avoid writing incorrect config files

    @wxiaoguang
    wxiaoguang committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    0c23771 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. Merge branch 'main' into secret_uris

    @wxiaoguang
    wxiaoguang committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    febf582 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2022

  1. Merge branch 'main' into secret_uris

    @wxiaoguang
    wxiaoguang committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    d8e26b4 View commit details
    Browse the repository at this point in the history