Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize JS build scripts #19824

Merged
merged 4 commits into from
Jun 6, 2022
Merged

Modernize JS build scripts #19824

merged 4 commits into from
Jun 6, 2022

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented May 28, 2022

  • Remove __dirname, use file URLs instead
  • Upgrade fabric dependency
  • Use fs/promises syntax, this breaks node 12 but we require 14 already
  • Add hashbang to build scripts so they can be run directly

The change in public/img/favicon.svg is not caused by the fabric upgrade, but it seems it was not properly generated when introduced as make generate-images produces the same diff on main branch.

- Remove __dirname, use file URLs instead
- Upgrade fabric dependency
- Use fs/promises syntax, this breaks node 12 but we require 14 already

The change in public/img/favicon.svg is not caused by the fabric
upgrade, but it seems it was not properly generated when introduced.
@silverwind silverwind added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 28, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 28, 2022
@Gusted Gusted added this to the 1.17.0 milestone Jun 5, 2022
@Gusted Gusted added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jun 5, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 5, 2022
@wxiaoguang wxiaoguang merged commit df0fb17 into go-gitea:main Jun 6, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 6, 2022
* giteaofficial/main:
  Move some repository related code into sub package (go-gitea#19711)
  A minimal change to replace data calls with attr as per guidelines (go-gitea#19900)
  Modernize JS build scripts (go-gitea#19824)
  [skip ci] Updated translations via Crowdin
  Update MAINTAINERS (go-gitea#19896)
@silverwind silverwind deleted the js-refactor branch June 8, 2022 08:17
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
- Remove __dirname, use file URLs instead
- Upgrade fabric dependency
- Use fs/promises syntax, this breaks node 12 but we require 14 already

The change in public/img/favicon.svg is not caused by the fabric
upgrade, but it seems it was not properly generated when introduced.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants