Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take a stab at porting existing components to Vue3 #20044
Take a stab at porting existing components to Vue3 #20044
Changes from 2 commits
62afdcf
0e8c81e
295c724
d3381fc
e4a9441
e8c5061
7b013b8
6deb736
d16b5db
466b248
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this option was moved to compile-time config, https://github.com/vuejs/core/tree/main/packages/vue#bundler-build-feature-flags, but it might just be that it's no longer necessary to get rid of devtools in prod build as the docs sound like it's disabled by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, compile-time config won't be evaluated at runtime, though. That is, I can't go via
window.config
anymore.The value is injected in
gitea/templates/base/head_script.tmpl
Line 14 in 0e8c81e
which in turn is defined in
gitea/modules/context/context.go
Line 703 in 0e8c81e
which in turn is derived from
gitea/modules/setting/setting.go
Lines 1015 to 1016 in 0e8c81e
… so … is there a way I can somehow read this from Node.js?