-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix user visible check #21210
Merged
Merged
Fix user visible check #21210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
please add a this case as test |
delvh
approved these changes
Sep 19, 2022
6543
approved these changes
Sep 19, 2022
Will add a test soon. |
lunny
reviewed
Sep 19, 2022
lunny
approved these changes
Sep 19, 2022
There are some consistency checks failing. Will have a look. |
ci fail related, fixtures are now inconsistent |
wxiaoguang
pushed a commit
that referenced
this pull request
Sep 20, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 22, 2022
* upstream/main: Use absolute links in feeds (go-gitea#21229) Prevent invalid behavior for file reviewing when loading more files (go-gitea#21230) Respect `REQUIRE_SIGNIN_VIEW` for packages (go-gitea#20873) Make Clone in VSCode link get updated correctly (go-gitea#21225) Configure golangci-lint to show all issues (go-gitea#21106) Fix user visible check (go-gitea#21210) Fix template bug of admin monitor (go-gitea#21208) Clarify that `ENABLE_SWAGGER` only influences the API docs, not the routes (go-gitea#21215) Enable fluid page layout on medium size viewports (go-gitea#21178) [API] teamSearch show teams with no members if user is admin (go-gitea#21204)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
topic/security
Something leaks user information or is otherwise vulnerable. Should be fixed!
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21206
If user and viewer are equal the method should return true.
Also the common organization check was wrong as
count
can never be less then 0.