Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use absolute links in feeds #21229

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Use absolute links in feeds #21229

merged 4 commits into from
Sep 21, 2022

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Sep 21, 2022

fixes #20864

@KN4CK3R KN4CK3R added this to the 1.18.0 milestone Sep 21, 2022
KN4CK3R
KN4CK3R commented Sep 21, 2022
View reviewed changes
routers/web/feed/convert.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 21, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 21, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 21, 2022
@techknowlogick techknowlogick merged commit f52fe82 into go-gitea:main Sep 21, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 22, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
96bc6db 
* upstream/main:
  Use absolute links in feeds (go-gitea#21229)
  Prevent invalid behavior for file reviewing when loading more files (go-gitea#21230)
  Respect `REQUIRE_SIGNIN_VIEW` for packages (go-gitea#20873)
  Make Clone in VSCode link get updated correctly (go-gitea#21225)
  Configure golangci-lint to show all issues (go-gitea#21106)
  Fix user visible check (go-gitea#21210)
  Fix template bug of admin monitor (go-gitea#21208)
  Clarify that `ENABLE_SWAGGER` only influences the API docs, not the routes (go-gitea#21215)
  Enable fluid page layout on medium size viewports (go-gitea#21178)
  [API] teamSearch show teams with no members if user is admin (go-gitea#21204)
@KN4CK3R KN4CK3R deleted the fix-20864 branch September 24, 2022 15:27
KN4CK3R added a commit to KN4CK3R/gitea that referenced this pull request Sep 26, 2022
@KN4CK3R @wxiaoguang @techknowlogick
Use absolute links in feeds (go-gitea#21229)
8305231 
fixes go-gitea#20864

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@KN4CK3R KN4CK3R mentioned this pull request Sep 26, 2022
Merged
techknowlogick added a commit that referenced this pull request Sep 26, 2022
@KN4CK3R @wxiaoguang @techknowlogick
Use absolute links in feeds (#21229) (#21265)
43b4c38 
Backport of #21229

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@6543 6543 added the backport/done All backports for this PR have been created label Oct 15, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.

RSS feeds use relative links (missing instance address)
7 participants
@KN4CK3R @silverwind @wxiaoguang @delvh @techknowlogick @GiteaBot @6543