Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable editing tags #23883

Merged
merged 3 commits into from
Apr 3, 2023
Merged

Disable editing tags #23883

merged 3 commits into from
Apr 3, 2023

Conversation

Zettat123
Copy link
Contributor

Fixes #23865

In GitHub, users cannot edit a tag.

So in this PR the edit button will not be shown if the release's IsTag is true

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 3, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 3, 2023
@lunny lunny added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels Apr 3, 2023
@lunny lunny added this to the 1.20.0 milestone Apr 3, 2023
@jolheiser jolheiser enabled auto-merge (squash) April 3, 2023 20:12
@jolheiser
Copy link
Member

🎺 🤖

@jolheiser jolheiser merged commit cb6ed84 into go-gitea:main Apr 3, 2023
@GiteaBot
Copy link
Contributor

GiteaBot commented Apr 3, 2023

I was unable to create a backport for 1.19. @Zettat123, please send one manually. 🍵

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Apr 3, 2023
@GiteaBot
Copy link
Contributor

GiteaBot commented Apr 3, 2023

I was unable to create a backport for 1.19. @Zettat123, please send one manually. 🍵

@jolheiser jolheiser removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 3, 2023
@Zettat123
Copy link
Contributor Author

Tags would not be displayed in the release list before #23243 so I think we do not need to backport to v1.19. I will remove the backport related labels.

@Zettat123 Zettat123 removed outdated/backport/v1.19 This PR should be backported to Gitea 1.19 backport/manual No power to the bots! Create your backport yourself! labels Apr 4, 2023
@Zettat123 Zettat123 deleted the bugfix/issue-23865 branch April 4, 2023 01:48
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 4, 2023
* upstream/main:
  Use User.ID instead of User.Name in ActivityPub API for Person IRI (go-gitea#23823)
  Remove fomantic ".link" selector and styles (go-gitea#23888)
  [skip ci] Updated translations via Crowdin
  Fix `cases.Title` crash for concurrency (go-gitea#23885)
  Disable editing tags (go-gitea#23883)
  Fix user profile description rendering (go-gitea#23882)
  Introduce GiteaLocaleNumber custom element to handle number localization on pages. (go-gitea#23861)
  Convert .Source.SkipVerify to $cfg.SkipVerify (go-gitea#23839)
  Fix review box viewport overflow issue (go-gitea#23800)
  Fix owner team access mode value in team_unit table (go-gitea#23675)
  Fix submit button won't refresh in New Repository Fork page (go-gitea#22994)
  Introduce GitHub markdown editor, keep EasyMDE as fallback (go-gitea#23876)
  Improve LoadUnitConfig to handle invalid or duplicate units (go-gitea#23736)
  Append `(comment)` when a link points at a comment rather than the whole issue (go-gitea#23734)
  Rename actions unit to `repo.actions` and add docs for it (go-gitea#23733)
  Try to catch more broken translations (go-gitea#23867)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing tags - ERROR 404
5 participants