Fix owner team access mode value in team_unit table #23675

yp05327 · 2023-03-24T02:33:58Z

All access_mode value of Owner Teams are 0(AccessModeNone) in team_unit table, which should be 4(AccessModeOwner)
In team table:

In team_unit table:

ps: In #23630, access_mode in team_unit is used to check the team unit permission, but I found that user can not see issues in owned org repos.

codecov-commenter · 2023-03-24T05:00:16Z

Codecov Report

Merging #23675 (fe0e75c) into main (f521e88) will increase coverage by 0.00%.
The diff coverage is 41.80%.

❗ Current head fe0e75c differs from pull request most recent head 54b3d7c. Consider uploading reports for the commit 54b3d7c to get more accurate results

@@           Coverage Diff            @@
##             main   #23675    +/-   ##
========================================
  Coverage   47.14%   47.14%            
========================================
  Files        1149     1155     +6     
  Lines      151446   152397   +951     
========================================
+ Hits        71397    71848   +451     
- Misses      71611    72076   +465     
- Partials     8438     8473    +35

Impacted Files	Coverage Δ
cmd/dump.go	`0.66% <0.00%> (-0.01%)`	⬇️
cmd/web.go	`0.00% <0.00%> (ø)`
models/actions/run.go	`1.64% <0.00%> (-0.08%)`	⬇️
models/actions/runner.go	`1.44% <ø> (ø)`
models/packages/package.go	`45.45% <0.00%> (-1.13%)`	⬇️
models/user/search.go	`77.50% <0.00%> (-6.29%)`	⬇️
modules/actions/workflows.go	`0.00% <0.00%> (ø)`
modules/context/context.go	`64.54% <0.00%> (-3.53%)`	⬇️
modules/doctor/storage.go	`30.65% <0.00%> (-1.29%)`	⬇️
modules/setting/git.go	`45.45% <ø> (ø)`
... and 38 more

... and 44 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

GiteaBot · 2023-04-03T14:36:42Z

I was unable to create a backport for 1.19. @yp05327, please send one manually. 🍵

* upstream/main: Use User.ID instead of User.Name in ActivityPub API for Person IRI (go-gitea#23823) Remove fomantic ".link" selector and styles (go-gitea#23888) [skip ci] Updated translations via Crowdin Fix `cases.Title` crash for concurrency (go-gitea#23885) Disable editing tags (go-gitea#23883) Fix user profile description rendering (go-gitea#23882) Introduce GiteaLocaleNumber custom element to handle number localization on pages. (go-gitea#23861) Convert .Source.SkipVerify to $cfg.SkipVerify (go-gitea#23839) Fix review box viewport overflow issue (go-gitea#23800) Fix owner team access mode value in team_unit table (go-gitea#23675) Fix submit button won't refresh in New Repository Fork page (go-gitea#22994) Introduce GitHub markdown editor, keep EasyMDE as fallback (go-gitea#23876) Improve LoadUnitConfig to handle invalid or duplicate units (go-gitea#23736) Append `(comment)` when a link points at a comment rather than the whole issue (go-gitea#23734) Rename actions unit to `repo.actions` and add docs for it (go-gitea#23733) Try to catch more broken translations (go-gitea#23867)

silverwind · 2023-04-09T12:33:06Z

Fixes #23474? I guess a backport would be nice if it does so I no longer need that workaround that I currently execute via cron every day 😆.

yp05327 · 2023-04-10T02:01:06Z

Fixes #23474? I guess a backport would be nice if it does so I no longer need that workaround that I currently execute via cron every day 😆.

It seems that we found this bug in a different way.
Your issue will be fixed if it is only caused by the incorrect AccessMode in TeamUnit table.

@lunny
Is it safe to only backport the code here?
https://github.com/go-gitea/gitea/pull/23675/files#diff-223cf46382a22079a281b568e5cfcb9648ed6a200d8768ea3283354205f1b508R341-R344

lunny · 2023-04-10T03:41:15Z

Fixes #23474? I guess a backport would be nice if it does so I no longer need that workaround that I currently execute via cron every day 😆.

It seems that we found this bug in a different way.

Your issue will be fixed if it is only caused by the incorrect AccessMode in TeamUnit table.

@lunny

Is it safe to only backport the code here?

https://github.com/go-gitea/gitea/pull/23675/files#diff-223cf46382a22079a281b568e5cfcb9648ed6a200d8768ea3283354205f1b508R341-R344

We can partially back port. All changes except migration could be back port.

yp05327 · 2023-04-13T05:18:17Z

@lunny
I found a problem when working on #24012

In #18675:

Don't allow TypeExternal{Tracker,Wiki} to influence this as they can only be set to READ perms.

So for owner team or admin team, Tracker and Wiki unit accessmode should be 1(read) in db?

Same as #23675 Feedback: #23879 (comment)

…24117) Fix the incorrect migration in #23675 and #24012 External Unit (Tracker and Wiki) access mode should be `read` in owner/admin team.

Add test for #23675 Should be merged after #24117 --------- Co-authored-by: silverwind <me@silverwind.io>

Partly backport #23675 Co-authored-by: Giteabot <teabot@gitea.io>

GiteaBot · 2023-08-01T16:01:09Z

We lock pull requests 3 months after they were closed. If there's any need for further discussion, please open a new issue. 🍵

fix owner team access mode

ee7b309

lunny added type/bug outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels Mar 24, 2023

lunny added this to the 1.20.0 milestone Mar 24, 2023

add db migration

a0a2480

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 24, 2023

lunny approved these changes Mar 24, 2023

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 24, 2023

yp05327 added 6 commits March 25, 2023 01:38

rename v249 to v250

9654b12

Merge branch 'main' into fix-owner-team-accessmode

2b7eb3d

fix lint

fe0e75c

convert v250 into v251

7e3cdaa

Merge branch 'main' into fix-owner-team-accessmode

aa4e783

fix lint

878feae

wolfogre approved these changes Apr 3, 2023

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 3, 2023

lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 3, 2023

Merge branch 'main' into fix-owner-team-accessmode

54b3d7c

jolheiser enabled auto-merge (squash) April 3, 2023 13:52

Merge branch 'main' into fix-owner-team-accessmode

8f80b08

jolheiser merged commit 6eb856c into go-gitea:main Apr 3, 2023
2 checks passed

GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Apr 3, 2023

go-gitea deleted a comment from GiteaBot Apr 3, 2023

jolheiser removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 3, 2023

yp05327 mentioned this pull request Apr 9, 2023

Fix admin team access mode value in team_unit table #24012

Merged

yp05327 mentioned this pull request Apr 9, 2023

Improve permission check of packages #23879

Merged

silverwind mentioned this pull request Apr 10, 2023

Some repos are missing in global and org code search #23474

Closed

yp05327 mentioned this pull request Apr 13, 2023

Add owner team permission check test #24096

Merged

6543 pushed a commit that referenced this pull request Apr 13, 2023

Fix admin team access mode value in team_unit table (#24012)

b7221be

Same as #23675 Feedback: #23879 (comment)

yp05327 mentioned this pull request Apr 14, 2023

Add migration to fix external unit access mode of owner/admin team #24117

Merged

6543 pushed a commit that referenced this pull request Apr 15, 2023

Add migration to fix external unit access mode of owner/admin team (#…

fa34951

…24117) Fix the incorrect migration in #23675 and #24012 External Unit (Tracker and Wiki) access mode should be `read` in owner/admin team.

silverwind added a commit that referenced this pull request Apr 19, 2023

Add owner team permission check test (#24096)

da6e9f6

Add test for #23675 Should be merged after #24117 --------- Co-authored-by: silverwind <me@silverwind.io>

yp05327 mentioned this pull request Apr 20, 2023

Fix owner team access mode value in team_unit table #24224

Merged

silverwind pushed a commit that referenced this pull request Apr 22, 2023

Fix owner team access mode value in team_unit table (#24224)

5ccb626

Partly backport #23675 Co-authored-by: Giteabot <teabot@gitea.io>

lunny added the backport/done All backports for this PR have been created label Jul 26, 2023

go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix owner team access mode value in team_unit table #23675

Fix owner team access mode value in team_unit table #23675

yp05327 commented Mar 24, 2023 •

edited

codecov-commenter commented Mar 24, 2023 •

edited

GiteaBot commented Apr 3, 2023

silverwind commented Apr 9, 2023 •

edited

yp05327 commented Apr 10, 2023

lunny commented Apr 10, 2023

yp05327 commented Apr 13, 2023

GiteaBot commented Aug 1, 2023

Fix owner team access mode value in team_unit table #23675

Fix owner team access mode value in team_unit table #23675

Conversation

yp05327 commented Mar 24, 2023 • edited

codecov-commenter commented Mar 24, 2023 • edited

Codecov Report

GiteaBot commented Apr 3, 2023

silverwind commented Apr 9, 2023 • edited

yp05327 commented Apr 10, 2023

lunny commented Apr 10, 2023

yp05327 commented Apr 13, 2023

GiteaBot commented Aug 1, 2023

yp05327 commented Mar 24, 2023 •

edited

codecov-commenter commented Mar 24, 2023 •

edited

silverwind commented Apr 9, 2023 •

edited