Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslints for Vue 3 #23935

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Conversation

jtran
Copy link
Contributor

@jtran jtran commented Apr 5, 2023

I found that some lint warnings in my editor are conflicting, and I believe the root cause is using lints designed for Vue 2 instead of Vue 3. We moved to Vue 3 in #20044.

I verified that the explicitly disabled rules in the changed file are still part of the vue/vue3-recommended set.

See Available rules - eslint-plugin-vue for a full list of lints.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 5, 2023
@techknowlogick techknowlogick added this to the 1.20.0 milestone Apr 5, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 5, 2023
@techknowlogick techknowlogick merged commit 8c3cee7 into go-gitea:main Apr 5, 2023
@jtran jtran deleted the jt/vue3-eslint branch April 5, 2023 21:00
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 6, 2023
* upstream/main:
  [skip ci] Updated translations via Crowdin
  Update eslints for Vue 3 (go-gitea#23935)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants