Use 1.18's aria role for dropdown menus #24144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed by issue reporter, I think this PR is ready. |
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Apr 16, 2023
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Apr 16, 2023
GiteaBot
added
lgtm/done
delvh
added
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## main #24144 +/- ##
==========================================
- Coverage 47.14% 47.10% -0.04%
==========================================
Files 1149 1161 +12
Lines 151446 153792 +2346
==========================================
+ Hits 71397 72448 +1051
- Misses 71611 72825 +1214
- Partials 8438 8519 +81
... and 160 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
GiteaBot
removed
the
reviewed/wait-merge
silverwind
added a commit
that referenced
this pull request
Apr 17, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 18, 2023
* giteaofficial/main: (25 commits) zh-cn support on doc pages (go-gitea#24166) [skip ci] Updated translations via Crowdin Use double quotes consistently in en-US (go-gitea#24141) Use correct locale key for forks page (go-gitea#24172) Improve Wiki TOC (go-gitea#24137) Localize activity heatmap (except tooltip) (go-gitea#24131) Support triggering workflows by wiki related events (go-gitea#24119) add CLI command to register runner tokens (go-gitea#23762) Add new user types `reserved`, `bot`, and `remote` (go-gitea#24026) Fix Org edit page bugs: renaming detection, maxlength (go-gitea#24161) Make HAS_GO a simply expanded variable (go-gitea#24169) Support converting varchar to nvarchar for mssql database (go-gitea#24105) Fix math and mermaid rendering bugs (go-gitea#24049) Refactor locale number (go-gitea#24134) [skip ci] Updated translations via Crowdin Use 1.18's aria role for dropdown menus (go-gitea#24144) Set EasyMDE heading font-size to the same size as the resulting markdown (go-gitea#24151) Fix 2-dot direct compare to use the right base commit (go-gitea#24133) Add migration to fix external unit access mode of owner/admin team (go-gitea#24117) Remove untranslatable `on_date` key (go-gitea#24106) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to erion's feedback, the 1.18 approach works with Safari (
role=menuon the parent container), while the 1.19's approach doesn't work well with Safari+VoiceOver (although I tested it worked with Chrome a little better).I have tested this 1.18 approach could work for all Safari/Chrome+VoiceOver and Chrome+Talkback.
Let's try to make it on try.gitea.io to see whether it helps Safari users.