Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set EasyMDE heading font-size to the same size as the resulting markdown #24151

Merged
merged 1 commit into from
Apr 16, 2023
Merged

Set EasyMDE heading font-size to the same size as the resulting markdown #24151

merged 1 commit into from
Apr 16, 2023

Conversation

wxiaoguang
Copy link
Contributor

Fix #23816

According to my personal experience, the EasyMDE is still useful when writing a lot of contents, eg: the wiki page.

It's not difficult to improve its heading styles, so let's make it.

Before:

image

After:

image

@wxiaoguang wxiaoguang changed the title Make EasyMDE has the same header(1-6) font-size as the markdown Make EasyMDE has the same heading(1-6) font-size as the markdown Apr 16, 2023
@wxiaoguang wxiaoguang mentioned this pull request Apr 16, 2023
Merged
@codecov-commenter

This comment was marked as off-topic.

Sign in to view
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 16, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 16, 2023
@delvh delvh added topic/ui-interaction Change the process how users use Gitea instead of the visual appearance javascript labels Apr 16, 2023
@delvh delvh added this to the 1.20.0 milestone Apr 16, 2023
@delvh delvh added backport/done All backports for this PR have been created outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels Apr 16, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 16, 2023
@delvh delvh changed the title Make EasyMDE has the same heading(1-6) font-size as the markdown Set EasyMDE heading font-size to the same size as the resulting markdown Apr 16, 2023
@lunny lunny merged commit 0e05984 into go-gitea:main Apr 16, 2023
@wxiaoguang wxiaoguang deleted the fix-easymde-h branch April 16, 2023 12:08
delvh pushed a commit that referenced this pull request Apr 16, 2023
@wxiaoguang
Set EasyMDE heading font-size to the same size as the resulting markd…
94fbd44 
…own (#24151) (#24152)

Backport #24151

Fix #23816

<img width="519" alt="image"
src="https://user-images.githubusercontent.com/2114189/232283304-21f56e82-d80e-4199-9b14-74699d80cd20.png">
@wxiaoguang wxiaoguang mentioned this pull request Apr 17, 2023
Closed
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 18, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
bab3026 
* giteaofficial/main: (25 commits)
  zh-cn support on doc pages (go-gitea#24166)
  [skip ci] Updated translations via Crowdin
  Use double quotes consistently in en-US (go-gitea#24141)
  Use correct locale key for forks page (go-gitea#24172)
  Improve Wiki TOC (go-gitea#24137)
  Localize activity heatmap (except tooltip) (go-gitea#24131)
  Support triggering workflows by wiki related events (go-gitea#24119)
  add CLI command to register runner tokens (go-gitea#23762)
  Add new user types `reserved`, `bot`, and `remote` (go-gitea#24026)
  Fix Org edit page bugs: renaming detection, maxlength (go-gitea#24161)
  Make HAS_GO a simply expanded variable (go-gitea#24169)
  Support converting varchar to nvarchar for mssql database (go-gitea#24105)
  Fix math and mermaid rendering bugs (go-gitea#24049)
  Refactor locale number (go-gitea#24134)
  [skip ci] Updated translations via Crowdin
  Use 1.18's aria role for dropdown menus (go-gitea#24144)
  Set EasyMDE heading font-size to the same size as the resulting markdown (go-gitea#24151)
  Fix 2-dot direct compare to use the right base commit (go-gitea#24133)
  Add migration to fix external unit access mode of owner/admin team (go-gitea#24117)
  Remove untranslatable `on_date` key (go-gitea#24106)
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yardenshoham yardenshoham yardenshoham approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 topic/ui-interaction Change the process how users use Gitea instead of the visual appearance
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

Font size of editor and preview should be the same
6 participants
@wxiaoguang @codecov-commenter @yardenshoham @delvh @lunny @GiteaBot