Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display creating page button in a mirror wiki repository #24395

Merged
merged 13 commits into from May 4, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 28, 2023

A mirror repository with wiki is also a mirror. So creating page from UI should be disabled. This PR hides the button like other places.

@lunny lunny added type/bug outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels Apr 28, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 28, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 28, 2023
@yp05327
Copy link
Contributor

yp05327 commented Apr 28, 2023

image
How about {{if and .CanWriteWiki (not .Repository.IsMirror)}}

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 28, 2023
@lunny
Copy link
Member Author

lunny commented Apr 29, 2023

image How about {{if and .CanWriteWiki (not .Repository.IsMirror)}}

Done.

@wxiaoguang
Copy link
Contributor

How about {{if and .CanWriteWiki (not .Repository.IsMirror)}}

Done.

Where is the (not .Repository.IsMirror) ?

image

@lunny lunny added this to the 1.20.0 milestone May 3, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 4, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 4, 2023
@lunny lunny merged commit b1cee3f into go-gitea:main May 4, 2023
15 checks passed
@lunny lunny deleted the lunny/fix_new_wiki_page_mirror branch May 4, 2023 07:27
@GiteaBot
Copy link
Contributor

GiteaBot commented May 4, 2023

I was unable to create a backport for 1.19. @lunny, please send one manually. 🍵

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels May 4, 2023
lunny added a commit to lunny/gitea that referenced this pull request May 4, 2023
…tea#24395)

A mirror repository with wiki is also a mirror. So creating page from UI
should be disabled. This PR hides the button like other places.
@lunny lunny mentioned this pull request May 4, 2023
@lunny lunny added the backport/done All backports for this PR have been created label May 4, 2023
silverwind pushed a commit that referenced this pull request May 4, 2023
backport #24395

---------

Co-authored-by: Giteabot <teabot@gitea.io>
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 5, 2023
* upstream/main:
  Harmonize title formatting in `docs/content/doc/development/api-usage.en-us.md` (go-gitea#24529)
  automate locking closed threads (go-gitea#24525)
  [skip ci] Updated translations via Crowdin
  Display warning when user try to rename default branch (go-gitea#24512)
  Upgrade to Node 20 on CI, enable actions cancellation (go-gitea#24524)
  Fix incorrectly quoted translation (go-gitea#24514)
  Fix color for transfer related buttons when having no permission to act (go-gitea#24510)
  Fix some mistakes when using `ignSignIn` (go-gitea#24415)
  Remove unused zapx replace statement on go.mod (go-gitea#24515)
  Don't display creating page button in a mirror wiki repository (go-gitea#24395)
  Improve template system and panic recovery (go-gitea#24461)
  Faster git.GetDivergingCommits (go-gitea#24482)
  Merge setting.InitXXX into one function with options (go-gitea#24389)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants