Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new wiki page mirror #24518

Merged
merged 3 commits into from May 4, 2023
Merged

Fix new wiki page mirror #24518

merged 3 commits into from May 4, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented May 4, 2023

backport #24395

lunny added 2 commits May 4, 2023 15:29
@lunny
Don't display creating page button in a mirror wiki repository (go-gi…
07d9858 
…tea#24395)

A mirror repository with wiki is also a mirror. So creating page from UI
should be disabled. This PR hides the button like other places.
@lunny
revert lang change
9e5de65
@lunny lunny added the type/bug label May 4, 2023
@lunny lunny added this to the 1.19.4 milestone May 4, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 4, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 4, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 4, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 4, 2023
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 4, 2023
@silverwind silverwind enabled auto-merge (squash) May 4, 2023 20:24
@silverwind silverwind merged commit 7a74957 into go-gitea:release/v1.19 May 4, 2023
1 of 2 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 4, 2023
@lunny lunny deleted the lunny/fix_new_wiki_page_mirror2 branch May 5, 2023 02:20
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.19.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lunny @silverwind @techknowlogick @GiteaBot