Rename actions tabs from Open/Closed to Running/Finished

[js6pak]

It doesn't make sense for actions to be open or closed so rename them to be running/finished.

---

Before:

With this change:

[lunny]

Some tasks are queue, canceled or failed. Is running/finished accurate enough?

[js6pak]

Cancelled and failed are both finished, just not successfully. For queued I'd say running is good enough.
Ideally there would be no tabs with everything being displayed by default and a filter option like the one github has.
That's beyond this PR though.

[wolfogre]

How about:

runs.open_tab = %d Ongoing
runs.closed_tab = %d Finished

• Keep open_tab and closed_tab unchanged, they are part of the code, not the UI. We should keep them consistent with NumClosedActionRuns.
• I don't think Running is good enough. It could be confusing with StatusRunning
• Finished looks good to me.

I'm not a native English speaker, just my opinions from coding.

[yardenshoham]

For reference, how GitHub classifies these

Why do we filter these? Let's just show both open and closed by default

[wxiaoguang]

I do not think "Running" is clear either.

I can accept Ongoing / Over

[silverwind]

I guess Active and Completed may be my favorite.

[js6pak]

@yardenshoham

For reference, how GitHub classifies these image

Why do we filter these? Let's just show both open and closed by default

That's exactly what I said here #24553 (comment)

Seeing as how everyone wants to name these tabs differently should we just skip this PR and go straight into removing the tabs altogether? I really don't see a point in showing only one of the state at the time.

[silverwind]

Yeah I guess actions just don't fit into the 2-state scheme like issues do. I havent' really checked this actions UI yet, but I assume these buttons are non-critical to usage, right?

[wxiaoguang]

I don't want to be too strict, so to clarify my opinion:

For "Open":

• "Open" is not ideal
• "Running" doesn't look good to me. Some are queued, not running
• "Ongoing / Active": look good to me

For "Close":

• "Close" is not ideal
• "Completed / Finished" doesn't look good to me, some could be canceled, not completed or finished.
  • But if there is strong preference, I won't block.
• "Over" is the proper word in my mind: the task is over, god knows what happens to it, just like "Game Over", the player could fail halfway, reach bad ending, or reach happy ending.

[yardenshoham]

Seeing as how everyone wants to name these tabs differently should we just skip this PR and go straight into removing the tabs altogether? I really don't see a point in showing only one of the state at the time.

I agree #24711

[lunny]

replaced by #24711