Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dashboard feed icon color #26552

Closed
wants to merge 1 commit into from
Closed

Fix dashboard feed icon color #26552

wants to merge 1 commit into from

Conversation

silverwind
Copy link
Member

#25790 had changed this icon color to body text color, revert it to previous shade. Before and after:

Screenshot 2023-08-17 at 02 02 35 Screenshot 2023-08-17 at 02 02 41

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 17, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 17, 2023
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Aug 17, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 17, 2023
@silverwind
Copy link
Member Author

silverwind commented Aug 18, 2023 •
edited
Loading

The icon also lost its margin on right side with #25790. I think it looks better with some margin, will check.

@silverwind silverwind marked this pull request as draft August 18, 2023 11:44
@silverwind silverwind mentioned this pull request Aug 28, 2023
Closed
@silverwind
Copy link
Member Author

Replaced by #26829.

@silverwind silverwind closed this Aug 30, 2023
@silverwind silverwind deleted the dashboard-icon branch August 30, 2023 22:13
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silverwind @wxiaoguang @GiteaBot