Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement code frequency graph #29191

Merged
merged 21 commits into from
Feb 23, 2024
Merged

Implement code frequency graph #29191

merged 21 commits into from
Feb 23, 2024

Conversation

sahinakkaya
Copy link
Contributor

@sahinakkaya sahinakkaya commented Feb 16, 2024 •
edited
Loading

Overview

This is the implementation of Code Frequency page. This feature was mentioned on these issues: #18262, #7392.

It adds another tab to Activity page called Code Frequency. Code Frequency tab shows additions and deletions over time since the repository existed.

Before:
image

After:
image

Features

  • See additions deletions over time since repository existed
  • Click on "Additions" or "Deletions" legend to show only one type of contribution
  • Use the same cache from Contributors page so that the loading of data will be fast once it is cached by visiting either one of the pages

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 16, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 16, 2024
@github-actions github-actions bot added modifies/translation modifies/api This PR adds API routes or modifies them modifies/frontend labels Feb 16, 2024
@github-actions github-actions bot removed the modifies/api This PR adds API routes or modifies them label Feb 16, 2024
@denyskon denyskon added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Feb 16, 2024
@sahinakkaya
Copy link
Contributor Author

The heaviest part of the work was done in #27882 so I could easily implement this with only 284 lines. I guess there is not a single unnecessary change so reviewing it will be easy. I hope we can also include this in v1.22 🤞

@KN4CK3R

This comment was marked as resolved.

Sign in to view
@sahinakkaya sahinakkaya mentioned this pull request Feb 17, 2024
Merged
@sahinakkaya sahinakkaya mentioned this pull request Feb 17, 2024
Closed
@lunny lunny mentioned this pull request Feb 17, 2024
Open
3 tasks
@sahinakkaya sahinakkaya changed the title Code frequency graph Implement code frequency graph Feb 19, 2024
@sahinakkaya sahinakkaya mentioned this pull request Feb 19, 2024
Merged
lunny pushed a commit that referenced this pull request Feb 19, 2024
@sahinakkaya
Deduplicate translations for contributors graph (#29256)
39a77d9 
I have implemented three graph pages
([contributors](#27882), [code
frequency](#29191) and [recent
commits](#29210)) and they have
all same page title as the tab name so I decided to use same
translations for them. This PR is for contributors graph. Other PR's
have their own respective commits.
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Feb 20, 2024
@sahinakkaya @earl-warren
Deduplicate translations for contributors graph (#29256)
8125fe0 
I have implemented three graph pages
([contributors](go-gitea/gitea#27882), [code
frequency](go-gitea/gitea#29191) and [recent
commits](go-gitea/gitea#29210)) and they have
all same page title as the tab name so I decided to use same
translations for them. This PR is for contributors graph. Other PR's
have their own respective commits.

(cherry picked from commit 39a77d92d9677b0a0049cb8696960d6d2ac052d6)
@6543 6543 added this to the 1.22.0 milestone Feb 20, 2024
@sahinakkaya
Copy link
Contributor Author

Review tip for maintainers: open #27882 and compare changes in this PR with the other PR. I copied files from the other PR.

silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@sahinakkaya @silverwind
Deduplicate translations for contributors graph (go-gitea#29256)
fff4bc2 
I have implemented three graph pages
([contributors](go-gitea#27882), [code
frequency](go-gitea#29191) and [recent
commits](go-gitea#29210)) and they have
all same page title as the tab name so I decided to use same
translations for them. This PR is for contributors graph. Other PR's
have their own respective commits.
@sahinakkaya
Copy link
Contributor Author

Is there anything I can do to speed up the review process? I have some spare time and waiting for your feedback. I might not be available starting from next month.

@silverwind silverwind removed the lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged label Feb 23, 2024
@silverwind
Copy link
Member

Blocked label seems obsolete so I removed it. Looks like a bug in giteabot, similar to #29210.

@silverwind silverwind mentioned this pull request Feb 23, 2024
Open
@silverwind silverwind added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 23, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 23, 2024
@delvh
Copy link
Member

delvh commented Feb 23, 2024

Sidenote, not a Giteabot bug, but weird GH (and Gitea) behavior:
A re-requested review is something else than a dismissed review for an unknown reason, so what you wanted was a dismiss review, but what you did is re-request review.
I've never understood why both are there, since only dismiss makes sense…

@silverwind
Copy link
Member

Sidenote, not a Giteabot bug, but weird GH (and Gitea) behavior: A re-requested review is something else than a dismissed review for an unknown reason, so what you wanted was a dismiss review, but what you did is re-request review. I've never understood why both are there, since only dismiss makes sense…

I always just click the "recycle" icon and it does it for me, but could be different for non-maintainers.

@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 23, 2024
@silverwind silverwind enabled auto-merge (squash) February 23, 2024 23:16
@silverwind silverwind merged commit 875f5ea into go-gitea:main Feb 23, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@denyskon denyskon denyskon approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
7 participants
@sahinakkaya @KN4CK3R @silverwind @delvh @denyskon @GiteaBot @6543