Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GPG subkey verify #30193

Merged
merged 3 commits into from
Mar 31, 2024
Merged

Fix GPG subkey verify #30193

merged 3 commits into from
Mar 31, 2024

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Mar 30, 2024

Fixes #30189

Can't verify subkeys if they are not loaded.

@KN4CK3R KN4CK3R added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 backport/v1.22 This PR should be backported to Gitea 1.22 labels Mar 30, 2024
@KN4CK3R KN4CK3R added this to the 1.22.0 milestone Mar 30, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 30, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 30, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 30, 2024
@KN4CK3R KN4CK3R mentioned this pull request Mar 30, 2024
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 30, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 30, 2024
@lafriks lafriks enabled auto-merge (squash) March 31, 2024 00:01
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 31, 2024
@lafriks lafriks merged commit 82ffd91 into go-gitea:main Mar 31, 2024
26 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Mar 31, 2024
@KN4CK3R @GiteaBot
Fix GPG subkey verify (go-gitea#30193)
e48f207 
Fixes go-gitea#30189

Can't verify subkeys if they are not loaded.
@GiteaBot GiteaBot mentioned this pull request Mar 31, 2024
Closed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Mar 31, 2024
@KN4CK3R @GiteaBot
Fix GPG subkey verify (go-gitea#30193)
bbd0ac1 
Fixes go-gitea#30189

Can't verify subkeys if they are not loaded.
@GiteaBot GiteaBot mentioned this pull request Mar 31, 2024
Merged
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 31, 2024
lafriks pushed a commit that referenced this pull request Mar 31, 2024
@GiteaBot @KN4CK3R
Fix GPG subkey verify (#30193) (#30203)
e581efe 
Backport #30193 by @KN4CK3R

Fixes #30189

Can't verify subkeys if they are not loaded.

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 31, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
fb637f0 
* giteaofficial/main:
  Do not allow different storage configurations to point to the same directory (go-gitea#30169)
  Fix GPG subkey verify (go-gitea#30193)
  [skip ci] Updated translations via Crowdin
  Fix unclickable checkboxes (go-gitea#30195)
  Remove jQuery class from the issue author dropdown (go-gitea#30188)
  Remove jQuery class from the comment edit history (go-gitea#30186)
  Remove jQuery class from the repository branch settings (go-gitea#30184)
  [skip ci] Updated translations via Crowdin
  Use Crowdin action for translation sync (go-gitea#30054)
  Remove jQuery class from the project page (go-gitea#30183)
  Remove jQuery class from the comment context menu (go-gitea#30179)
@KN4CK3R KN4CK3R deleted the fix-subkey-verify branch March 31, 2024 08:03
@GiteaBot GiteaBot mentioned this pull request Mar 31, 2024
Closed
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.22. @KN4CK3R, please send one manually. 🍵

go run ./contrib/backport 30193
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Mar 31, 2024
@silverwind silverwind removed the backport/v1.21 This PR should be backported to Gitea 1.21 label Mar 31, 2024
@silverwind silverwind mentioned this pull request Mar 31, 2024
Closed
@yardenshoham yardenshoham added backport/done All backports for this PR have been created and removed backport/manual No power to the bots! Create your backport yourself! labels Mar 31, 2024
@delvh delvh mentioned this pull request Apr 1, 2024
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lafriks lafriks lafriks approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Cannot verify GPG key. Armored GPG signature not accepted
6 participants
@KN4CK3R @GiteaBot @silverwind @lafriks @delvh @yardenshoham