Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jQuery class from the project page #30183

Merged
merged 2 commits into from
Mar 30, 2024
Merged

Remove jQuery class from the project page #30183

merged 2 commits into from
Mar 30, 2024

Conversation

yardenshoham
Copy link
Member

@yardenshoham yardenshoham commented Mar 30, 2024 •
edited

  • Switched from jQuery class functions to plain JavaScript classList
  • Tested the edit column modal functionality and it works as before

@yardenshoham
Remove jQuery class from the project page
93ea3f8 
- Switched from jQuery class functions to plain JavaScript 'classList`
- Tested the edit column modal functionality and it works as before

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 30, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 30, 2024
@yardenshoham yardenshoham added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 30, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 30, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 30, 2024
@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 30, 2024
@silverwind silverwind merged commit b535c6c into go-gitea:main Mar 30, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 30, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 30, 2024
@yardenshoham yardenshoham deleted the repo-projects-jquery-class branch March 30, 2024 17:41
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 31, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
fb637f0 
* giteaofficial/main:
  Do not allow different storage configurations to point to the same directory (go-gitea#30169)
  Fix GPG subkey verify (go-gitea#30193)
  [skip ci] Updated translations via Crowdin
  Fix unclickable checkboxes (go-gitea#30195)
  Remove jQuery class from the issue author dropdown (go-gitea#30188)
  Remove jQuery class from the comment edit history (go-gitea#30186)
  Remove jQuery class from the repository branch settings (go-gitea#30184)
  [skip ci] Updated translations via Crowdin
  Use Crowdin action for translation sync (go-gitea#30054)
  Remove jQuery class from the project page (go-gitea#30183)
  Remove jQuery class from the comment context menu (go-gitea#30179)
@silverwind
Copy link
Member

silverwind commented Apr 7, 2024 •
edited

Let's backport this so that backport #30237 can be automatic.

Edit: will backport both at once.

@silverwind silverwind added backport/v1.22 This PR should be backported to Gitea 1.22 and removed backport/v1.22 This PR should be backported to Gitea 1.22 labels Apr 7, 2024
silverwind pushed a commit to silverwind/gitea that referenced this pull request Apr 7, 2024
@yardenshoham @silverwind
Fix and rewrite contrast color calculation, fix project-related bugs
8a0e808 
Also includes go-gitea#30183
@silverwind silverwind mentioned this pull request Apr 7, 2024
Merged
silverwind added a commit to silverwind/gitea that referenced this pull request Apr 7, 2024
@silverwind
Fix and rewrite contrast color calculation, fix project-related bugs
1fbe0c1 
Also includes go-gitea#30183
silverwind added a commit that referenced this pull request Apr 9, 2024
@silverwind @GiteaBot
Fix and rewrite contrast color calculation, fix project-related bugs (#…
b8e9d3c 
…30326)

Backport #30237 to 1.22. Also
includes #30183. Both were clean
cherry-picks.

Co-authored-by: Giteabot <teabot@gitea.io>
@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yardenshoham @silverwind @delvh @wxiaoguang @GiteaBot