Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty field login_name in API response JSON when creating user (#30511) #30516

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Fix empty field login_name in API response JSON when creating user (#30511) #30516

merged 1 commit into from
Apr 16, 2024

Conversation

GiteaBot
Copy link
Contributor

Backport #30511 by @yp05327

Fix #30508

ps: if sourceID is not set, LoginName will be ignored

@GiteaBot GiteaBot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code topic/api Concerns mainly the API type/bug labels Apr 16, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone Apr 16, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 16, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 16, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 16, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 16, 2024
@silverwind silverwind merged commit f9a025f into go-gitea:release/v1.22 Apr 16, 2024
26 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

@appleboy appleboy Awaiting requested review from appleboy

@wolfogre wolfogre Awaiting requested review from wolfogre

Assignees

@yp05327 yp05327

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/api Concerns mainly the API type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @lunny @silverwind @yp05327