Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid importing modules/web/middleware in modules/session (#30584) #30589

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Avoid importing modules/web/middleware in modules/session (#30584) #30589

merged 2 commits into from
Apr 19, 2024

Conversation

GiteaBot
Copy link
Contributor

Backport #30584 by @wolfogre

Related to #30375.

It doesn't make sense to import modules/web/middleware and modules/setting in modules/web/session since the last one is more low-level.

And it looks like a workaround to call DeleteLegacySiteCookie in RegenerateSession, so maybe we could reverse the importing by registering hook functions.

@wolfogre @GiteaBot
Avoid importing modules/web/middleware in modules/session (go-git…
ba54b83 
…ea#30584)

Related to go-gitea#30375.

It doesn't make sense to import `modules/web/middleware` and
`modules/setting` in `modules/web/session` since the last one is more
low-level.

And it looks like a workaround to call `DeleteLegacySiteCookie` in
`RegenerateSession`, so maybe we could reverse the importing by
registering hook functions.
@GiteaBot GiteaBot added modifies/go Pull requests that update Go code type/enhancement An improvement of existing functionality labels Apr 19, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone Apr 19, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 19, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 19, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 19, 2024
@wolfogre wolfogre added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 19, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 19, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 19, 2024
@silverwind silverwind enabled auto-merge (squash) April 19, 2024 07:17
@silverwind silverwind merged commit 199397a into go-gitea:release/v1.22 Apr 19, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 19, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

Assignees

@wolfogre wolfogre

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @lunny @silverwind @wolfogre