Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protected tag is no internal server error #30962

Merged
merged 5 commits into from
May 14, 2024
Merged

Protected tag is no internal server error #30962

merged 5 commits into from
May 14, 2024

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented May 13, 2024 •
edited

Fixes #30959

Adds an API test for protected tags.
Fix existing tag in combination with fixtures.

@KN4CK3R KN4CK3R added this to the 1.22.0 milestone May 13, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 13, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 13, 2024
@KN4CK3R KN4CK3R added the backport/v1.22 This PR should be backported to Gitea 1.22 label May 13, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code and removed backport/v1.22 This PR should be backported to Gitea 1.22 labels May 13, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 13, 2024
@wxiaoguang wxiaoguang added the backport/v1.22 This PR should be backported to Gitea 1.22 label May 13, 2024
@silverwind
Copy link
Member

I think you need to alter swagger comment docs to indicate the possibility for any new status codes.

@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 13, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 13, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 14, 2024
@lunny lunny enabled auto-merge (squash) May 14, 2024 06:21
@lunny lunny merged commit b1d8f13 into go-gitea:main May 14, 2024
26 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 14, 2024
@KN4CK3R @GiteaBot
Protected tag is no internal server error (go-gitea#30962)
cdb47b0 
Fixes go-gitea#30959

Adds an API test for protected tags.
Fix existing tag in combination with fixtures.
@GiteaBot GiteaBot mentioned this pull request May 14, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels May 14, 2024
KN4CK3R added a commit that referenced this pull request May 14, 2024
@GiteaBot @KN4CK3R
Protected tag is no internal server error (#30962) (#30970)
8393ff7 
Backport #30962 by @KN4CK3R

Fixes #30959

Adds an API test for protected tags.
Fix existing tag in combination with fixtures.

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 14, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
f35d360 
* giteaofficial/main:
  Protected tag is no internal server error (go-gitea#30962)
  [skip ci] Updated translations via Crowdin
  Restyle release list, fix branch dropdown (go-gitea#30837)
  fix: change npm scope registry (go-gitea#30964)
  Support using label names when changing issue labels (go-gitea#30943)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Weird HTTP code when invalid tag name is provided
5 participants
@KN4CK3R @silverwind @lunny @wxiaoguang @GiteaBot