Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change npm scope registry #30964

Merged
merged 2 commits into from
May 13, 2024
Merged

fix: change npm scope registry #30964

merged 2 commits into from
May 13, 2024

Conversation

llxlr
Copy link
Contributor

@llxlr llxlr commented May 13, 2024

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 13, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 13, 2024
@lng2020 lng2020 added the backport/v1.22 This PR should be backported to Gitea 1.22 label May 13, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 13, 2024
@lunny lunny merged commit 8218b64 into go-gitea:main May 13, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 13, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 13, 2024
@llxlr @GiteaBot
fix: change npm scope registry (go-gitea#30964)
6a8c965 
https://docs.npmjs.com/cli/v10/using-npm/scope#associating-a-scope-with-a-registry
@GiteaBot GiteaBot mentioned this pull request May 13, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label May 13, 2024
@silverwind
Copy link
Member

FYI I tested this, both variants work.

silverwind pushed a commit that referenced this pull request May 13, 2024
@GiteaBot @llxlr
fix: change npm scope registry (#30964) (#30965)
70eaa99 
Backport #30964 by @llxlr


https://docs.npmjs.com/cli/v10/using-npm/scope#associating-a-scope-with-a-registry

Co-authored-by: james yang <yanghongday369@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 14, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
f35d360 
* giteaofficial/main:
  Protected tag is no internal server error (go-gitea#30962)
  [skip ci] Updated translations via Crowdin
  Restyle release list, fix branch dropdown (go-gitea#30837)
  fix: change npm scope registry (go-gitea#30964)
  Support using label names when changing issue labels (go-gitea#30943)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

@lng2020 lng2020 lng2020 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@llxlr @silverwind @wxiaoguang @a1012112796 @lng2020 @lunny @GiteaBot