Fix missing branch in release bug #3108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to add migration to fix broken data? |
tboerger
added
the
lgtm/need 2
|
@lafriks There's no way to know what branch the releases were intended to be targeted against. |
lunny
requested changes
Dec 8, 2017
modules/test/context_tests.go
Outdated
| @@ -51,6 +52,13 @@ func LoadUser(t *testing.T, ctx *context.Context, userID int64) { | |||
| ctx.User = models.AssertExistsAndLoadBean(t, &models.User{ID: userID}).(*models.User) | |||
| } | |||
|
|
|||
| func LoadGitRepo(t *testing.T, ctx *context.Context) { | |||
There was a problem hiding this comment.
No. you didn't, it should LoadGitRepo not LoadRepo.
There was a problem hiding this comment.
good catch, actually fixed now
ethantkoenig
force-pushed
the
fix/releases
branch
from
4f39bb6
to
0a5c6c3
Compare
ethantkoenig
force-pushed
the
fix/releases
branch
from
0a5c6c3
to
d52da55
Compare
Codecov Report
@@ Coverage Diff @@
## master #3108 +/- ##
==========================================
- Coverage 34.04% 34.02% -0.03%
==========================================
Files 274 274
Lines 40020 40026 +6
==========================================
- Hits 13626 13620 -6
- Misses 24455 24466 +11
- Partials 1939 1940 +1
Continue to review full report at Codecov.
|
|
LGTM |
tboerger
added
lgtm/need 1
lunny
approved these changes
Dec 8, 2017
|
LGTM |
tboerger
added
lgtm/done
|
@ethantkoenig please send a backport to release/v1.3 |
ethantkoenig
added a commit
to ethantkoenig/gitea
that referenced
this pull request
Dec 8, 2017
lunny
pushed a commit
that referenced
this pull request
Dec 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3066. Previously, the
targetof a release would not be set if the tag already existed.