Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Make cookies HttpOnly and obey COOKIE_SECURE flag (#4706) #4707

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

SagePtr
Copy link
Contributor

@SagePtr SagePtr commented Aug 14, 2018

Backport of #4706 in case if it will be needed.

@techknowlogick techknowlogick added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Aug 14, 2018
@techknowlogick techknowlogick added this to the 1.5.1 milestone Aug 14, 2018
@techknowlogick techknowlogick added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Aug 14, 2018
@techknowlogick
Copy link
Member

blocked pending merge of other PR

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 14, 2018
@lafriks lafriks removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Aug 14, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 14, 2018
@lafriks
Copy link
Member

lafriks commented Aug 14, 2018

In future please backport only after PR to master branch has been merged

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 14, 2018
@techknowlogick techknowlogick merged commit 052aa54 into go-gitea:release/v1.5 Aug 14, 2018
@SagePtr SagePtr deleted the cookies-backport branch August 14, 2018 21:57
@SagePtr SagePtr restored the cookies-backport branch August 14, 2018 23:19
@SagePtr SagePtr deleted the cookies-backport branch August 14, 2018 23:25
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants