Feature: Archive repos #5009

kolaente · 2018-10-03T14:58:13Z

This pr adds the ability to archive a repo, as described in #1353.

When a repo is archived, it is not possible to push to it, neither the creation of new issues or pull requests. In all lists (~Dashboard/Search/Explore/Profiles), the repo is marked with a tiny inicator if its archived.

Blocked by go-gitea/go-sdk#122

Off-Topic: I actually don't know why this pr shows up with 391 commits 🤔, so if anyone knows how to resolve this, please tell me.

Screenshots

lafriks · 2018-10-03T15:13:52Z

Do not merge with master but try rebasing on master branch

kolaente · 2018-10-03T15:50:06Z

@lafriks done (actually, resetting was much faster)

kolaente · 2018-10-03T16:11:41Z

I tried to use this icon for the "this repo is archived"-indicator, but it seems like the version of octicon we're using is outdated. After that, I looked for a way to update it (in a seperate pr) but apparantly github has removed icon font usage entirely, meaning we'd need to update every icon in the whole project to use svg icons instead...

So I'm sticking with the icon from semantic ui for now.

routers/repo/http.go

jonasfranz · 2018-10-05T09:35:56Z

routers/repo/setting.go

+		}
+		if err := repo.ToggleArchiveRepo(); err != nil {
+			log.Error(4, "Tried to archive a repo: %s", err)
+			ctx.Error(500)


This will be ignored since ctx.Redirect will use a 3XX HTTP code.

jonasfranz

It is possible to add/upload new files although the repo is archived.

Editing an existing file is possible too.

…chived

codecov-io · 2018-10-06T20:51:26Z

Codecov Report

Merging #5009 into master will decrease coverage by 0.04%.
The diff coverage is 30.88%.

@@            Coverage Diff             @@
##           master    #5009      +/-   ##
==========================================
- Coverage   37.93%   37.89%   -0.05%     
==========================================
  Files         328      328              
  Lines       48141    48190      +49     
==========================================
- Hits        18264    18261       -3     
- Misses      27252    27299      +47     
- Partials     2625     2630       +5

Impacted Files	Coverage Δ
modules/auth/repo_form.go	`39% <ø> (ø)`	⬆️
routers/repo/setting.go	`10.41% <0%> (-0.77%)`	⬇️
routers/repo/http.go	`38.17% <0%> (-0.42%)`	⬇️
routers/repo/release.go	`33.04% <100%> (ø)`	⬆️
routers/repo/view.go	`47.3% <100%> (ø)`	⬆️
routers/repo/wiki.go	`44.59% <100%> (ø)`	⬆️
models/repo.go	`43.81% <20%> (-0.08%)`	⬇️
modules/context/repo.go	`59.57% <50%> (-0.21%)`	⬇️
routers/routes/routes.go	`85.05% <92.3%> (ø)`	⬆️
models/repo_indexer.go	`44.49% <0%> (-3.82%)`	⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ad834e...746f9a9. Read the comment docs.

routers/repo/editor.go

models/repo.go

kolaente · 2018-10-07T18:02:55Z

You mean I should just explicitly check if the repo is archived when someone tries to create an issue/pr?
I tried to do exactly this, but I figured it would be much easier to just disable issue/pr creation when I archive a repo... What do you think about disabling the "re-enabling" of issue/pr when a repo is archived?

lunny · 2018-10-08T00:44:37Z

@kolaente maybe somebody want to search issues on an archive repo?

adelowo · 2019-01-20T14:30:02Z

By the way, wouldn't we want to make it request for the name of
the repository as with other actions in the Danger Zone?

adelowo · 2019-01-20T14:32:45Z

On GitHub when a repo is archived, its name and some other options cannot be updated.

kolaente · 2019-01-22T20:18:52Z

@adelowo I don't think it's nessecary to have a name-check as this can easily be undone, not like renaming the repo.

kolaente · 2019-01-22T20:20:57Z

@adelowo which other changes cannot be updated in github?

techknowlogick · 2019-01-23T18:18:12Z

@kolaente conflict with CSS

@jonasfranz please update review

kolaente · 2019-01-23T18:24:08Z

@techknowlogick resolved conflicts

Changes have been made

techknowlogick · 2019-01-23T18:58:50Z

@kolaente Thanks 😄

theAkito · 2019-01-23T19:06:13Z

I have been waiting so long for this feature and now it has been finally added!

kolaente · 2019-01-23T19:52:54Z

Thanks for merging this!

adelowo · 2019-01-24T12:01:03Z

template: repo/header:11:10: executing "repo/header" at <.IsArchived>: can't evaluate field IsArchived in type *models.Repository

This didn't come with a migration. I keep on getting this error.
Looking at the history of the migrations folder, I cannot see anything related: https://github.com/go-gitea/gitea/commits/master/models/migrations

I know when I tested earlier, it was fine :)

kolaente · 2019-01-24T12:03:12Z

Did it create the table column? Normally it syncs all structs automatically, so it should exist (which is why I didn't create a dedicated migration).

adelowo · 2019-01-24T12:24:22Z

is_archived is in the table. I just tried this on a new database ( from scratch ) and still the same thing :). My master branch is clean though.

kolaente · 2019-01-24T12:32:59Z

Did you customize the header?

kolaente · 2019-01-24T12:33:19Z

I just tried it on try.gitea.io where it works without issues...

adelowo · 2019-01-24T12:42:21Z

Did you customize the header?

No... I do have a clean branch, no customizations

Will go get again :)

adelowo · 2019-01-24T13:23:12Z

No idea why rm -rf and go get worked again. I am 100% I had a clean branch but it's solved already.

/shrug

kolaente mentioned this pull request Oct 3, 2018

Feature/archive repos go-gitea/go-sdk#122

Merged

bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 3, 2018

lafriks added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Oct 3, 2018

Rebased to gitea-master

16a96f3

kolaente force-pushed the feature/archive-repos branch from 062b168 to 16a96f3 Compare October 3, 2018 15:48

jonasfranz suggested changes Oct 5, 2018

View reviewed changes

lunny added this to the 1.7.0 milestone Oct 5, 2018

kolaente added 11 commits October 5, 2018 23:05

Updated gitea/go-sdk

232f71e

Removed unused setting of status code

fbf39fe

Added error message if archiving fails

8655d0e

updated gitea go-sdk

6f53048

Prevent adding/editing/removing of files via web ui when a repo is ar…

b365cd9

…chived

generated swagger

34c1419

fmt

a7cc8fa

trigger ci

3877a2d

trigger ci

9c366eb

fixed fmt (make fmt does not work)

4b38053

fixed fmt (make fmt does not work)

d94b479

lunny requested changes Oct 7, 2018

View reviewed changes

routers/repo/editor.go Outdated Show resolved Hide resolved

models/repo.go Outdated Show resolved Hide resolved

kolaente added 2 commits October 11, 2018 21:31

Moved check if a repo is archived to appropriate function

b4fb9cd

Moved functions to restrict upload/editing of files to a middleware

afa879a

adelowo mentioned this pull request Oct 11, 2018

Implement "conversation lock" for issue comments #5073

Merged

5 tasks

Removed deleting repo units to disable issues/pull requests

88a916e

kolaente added 2 commits January 17, 2019 10:14

Merge branch 'master' into feature/archive-repos

559b4cf

merge with master

06b99c9

merge with master

280baa5

kolaente added 2 commits January 22, 2019 22:16

Merge branch 'master' into feature/archive-repos

0a118f0

Fixed wrong order of ignerr

71d9305

merge with gitea-master

746f9a9

techknowlogick merged commit 0b51072 into go-gitea:master Jan 23, 2019

kolaente deleted the feature/archive-repos branch January 23, 2019 19:52

bmackinney pushed a commit to bmackinney/gitea that referenced this pull request Jan 27, 2019

Feature: Archive repos (go-gitea#5009)

7bda001

adelowo mentioned this pull request Mar 7, 2019

Add unit types to repo action URL to correctly show 404 when archived #6247

Merged

go-gitea locked and limited conversation to collaborators Nov 24, 2020

delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Archive repos #5009

Feature: Archive repos #5009

kolaente commented Oct 3, 2018 •

edited

Loading

lafriks commented Oct 3, 2018

kolaente commented Oct 3, 2018

kolaente commented Oct 3, 2018

jonasfranz Oct 5, 2018

jonasfranz left a comment •

edited

Loading

codecov-io commented Oct 6, 2018 •

edited

Loading

kolaente commented Oct 7, 2018

lunny commented Oct 8, 2018

adelowo commented Jan 20, 2019 •

edited

Loading

adelowo commented Jan 20, 2019

kolaente commented Jan 22, 2019

kolaente commented Jan 22, 2019

techknowlogick commented Jan 23, 2019

kolaente commented Jan 23, 2019

techknowlogick commented Jan 23, 2019

theAkito commented Jan 23, 2019

kolaente commented Jan 23, 2019

adelowo commented Jan 24, 2019 •

edited

Loading

kolaente commented Jan 24, 2019 •

edited

Loading

adelowo commented Jan 24, 2019

kolaente commented Jan 24, 2019

kolaente commented Jan 24, 2019

adelowo commented Jan 24, 2019

adelowo commented Jan 24, 2019

Feature: Archive repos #5009

Feature: Archive repos #5009

Conversation

kolaente commented Oct 3, 2018 • edited Loading

Screenshots

lafriks commented Oct 3, 2018

kolaente commented Oct 3, 2018

kolaente commented Oct 3, 2018

jonasfranz Oct 5, 2018

Choose a reason for hiding this comment

jonasfranz left a comment • edited Loading

Choose a reason for hiding this comment

codecov-io commented Oct 6, 2018 • edited Loading

Codecov Report

kolaente commented Oct 7, 2018

lunny commented Oct 8, 2018

adelowo commented Jan 20, 2019 • edited Loading

adelowo commented Jan 20, 2019

kolaente commented Jan 22, 2019

kolaente commented Jan 22, 2019

techknowlogick commented Jan 23, 2019

kolaente commented Jan 23, 2019

techknowlogick commented Jan 23, 2019

theAkito commented Jan 23, 2019

kolaente commented Jan 23, 2019

adelowo commented Jan 24, 2019 • edited Loading

kolaente commented Jan 24, 2019 • edited Loading

adelowo commented Jan 24, 2019

kolaente commented Jan 24, 2019

kolaente commented Jan 24, 2019

adelowo commented Jan 24, 2019

adelowo commented Jan 24, 2019

kolaente commented Oct 3, 2018 •

edited

Loading

jonasfranz left a comment •

edited

Loading

codecov-io commented Oct 6, 2018 •

edited

Loading

adelowo commented Jan 20, 2019 •

edited

Loading

adelowo commented Jan 24, 2019 •

edited

Loading

kolaente commented Jan 24, 2019 •

edited

Loading