Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Accept web-command cli flags if web-command is commited #5200

Merged
merged 8 commits into from
Nov 1, 2018
Merged

fix: Accept web-command cli flags if web-command is commited #5200

merged 8 commits into from
Nov 1, 2018

Conversation

HoffmannP
Copy link
Contributor

  • Added flags of default cmd CmdWeb to app-wide flags
  • If command is specified app-wide flags are ignored

Resolves: #5065
Signed-off-by: Berengar W. Lehr Berengar.Lehr@kompetenztest.de

* Added flags of default cmd CmdWeb to app-wide flags
* If command *is* specified app-wide flags are ignored

Resolves: #5065
Signed-off-by: Berengar W. Lehr <Berengar.Lehr@kompetenztest.de>
@codecov-io
Copy link

codecov-io commented Oct 27, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@6c90dd1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5200   +/-   ##
=========================================
  Coverage          ?   37.48%           
=========================================
  Files             ?      310           
  Lines             ?    45923           
  Branches          ?        0           
=========================================
  Hits              ?    17213           
  Misses            ?    26236           
  Partials          ?     2474

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c90dd1...6e90f6e. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 27, 2018
@lunny lunny added the type/bug label Oct 27, 2018
@lunny lunny added this to the 1.7.0 milestone Oct 27, 2018
main.go Outdated
@@ -13,6 +13,7 @@ import (
"code.gitea.io/gitea/cmd"
"code.gitea.io/gitea/modules/log"
"code.gitea.io/gitea/modules/setting"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to remove this newline?

@techknowlogick
Copy link
Member

One nit, but once that is resolved I'll be happy to complete my review.

Thanks for PR 😄

* broken windows need to be fixed
* provides requested change
@HoffmannP
Copy link
Contributor Author

@techknowlogick nit was removed, is there anything else I can do?

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 30, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 31, 2018
@techknowlogick techknowlogick merged commit 584844e into go-gitea:master Nov 1, 2018
@lunny
Copy link
Member

lunny commented Nov 1, 2018

@HoffmannP please send back port to release/v1.6

@HoffmannP HoffmannP deleted the issue/#5065_no_ignore_flag_default_web branch November 1, 2018 08:56
techknowlogick pushed a commit that referenced this pull request Nov 1, 2018
* Added flags of default cmd CmdWeb to app-wide flags
* If command *is* specified app-wide flags are ignored

Backport of #5200
Signed-off-by: Berengar W. Lehr <Berengar.Lehr@kompetenztest.de>
@lafriks lafriks added the backport/done All backports for this PR have been created label Nov 8, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

./gitea without 'web' ignores commandline flags
7 participants