Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create stale bot config #5243

Merged
merged 15 commits into from
Dec 20, 2018
Merged

Conversation

sapk
Copy link
Member

@sapk sapk commented Nov 1, 2018

https://github.com/probot/stale

For this to work someone of @go-gitea/owners need to activate https://github.com/apps/stale

For starting, I choose 2 month of inactivity and 2 weeks after the issue or PR is closed. I limit to 1 action/hour the bot.

The following labels are skipped :

  • status/blocked
  • kind/security
  • lgtm/done
  • reviewed/confirmed
  • priority/critical
  • kind/proposal

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 1, 2018
@sapk
Copy link
Member Author

sapk commented Nov 1, 2018

We maybe need a label reviewed/confirmed to lock some issue that shouldn't be closed. Done

@codecov-io
Copy link

codecov-io commented Nov 1, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@8dc09ed). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5243   +/-   ##
=========================================
  Coverage          ?   37.54%           
=========================================
  Files             ?      321           
  Lines             ?    47192           
  Branches          ?        0           
=========================================
  Hits              ?    17716           
  Misses            ?    26931           
  Partials          ?     2545

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dc09ed...e6c1ca7. Read the comment docs.

@lafriks
Copy link
Member

lafriks commented Nov 1, 2018

@sapk I have added reviewed/confirmed label

@jonasfranz
Copy link
Member

Also add priority/critical please

.github/stale.yml Outdated Show resolved Hide resolved
@sapk
Copy link
Member Author

sapk commented Nov 1, 2018

Should we exclude the label kind/proposal ?

@jonasfranz
Copy link
Member

jonasfranz commented Nov 1, 2018 via email

.github/stale.yml Outdated Show resolved Hide resolved
@HoffmannP
Copy link
Contributor

If these two labels (critical & confirmed) where just added current issues that would be closed in january should be re-checked?

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 4, 2018
@sapk
Copy link
Member Author

sapk commented Nov 4, 2018

@HoffmannP The goal is more to help closed issue without responses and auto-close them. This also define a general rule when to consider a issue as stale and can be closed. Actually this is done manually and some can found it hard do find when to close and when not to close.

@lunny
Copy link
Member

lunny commented Nov 7, 2018

We have 133 open issues with kind/bug label inactive on last 60 days.
https://github.com/go-gitea/gitea/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+label%3Akind%2Fbug+updated%3A%3C2018-09-07+

@lafriks
Copy link
Member

lafriks commented Nov 7, 2018

We should probably review these issues and add needed labels for issues that should not be closed before merging this PR.

@bkcsoft bkcsoft removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 9, 2018
@bkcsoft bkcsoft added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 9, 2018
@techknowlogick
Copy link
Member

I will merge this, but it requires an Owner to activate the bot.

@techknowlogick techknowlogick merged commit 7cb1d82 into go-gitea:master Dec 20, 2018
@sapk sapk deleted the add-stale-bot branch January 5, 2019 15:10
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants