Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add changelog of v1.6.0 #5379

Merged
merged 2 commits into from
Nov 23, 2018
Merged

add changelog of v1.6.0 #5379

merged 2 commits into from
Nov 23, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 22, 2018

No description provided.

@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 22, 2018
@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Nov 22, 2018
@lafriks
Copy link
Member

lafriks commented Nov 22, 2018

Maybe reorder?

  • BREAKING
  • SECURITY
  • FEATURE
  • ENHANCEMENT
  • BUGFIXES
  • TRANSLATION

@lafriks lafriks added this to the 1.6.0 milestone Nov 22, 2018
@strk
Copy link
Member

strk commented Nov 22, 2018

LGTM, although I'd prefer less details in the bugfixes section (maybe move it as last thing, minor releases are mostly interesting for features, not bugfixes, which should go in bugfix releases)

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 22, 2018
@strk
Copy link
Member

strk commented Nov 22, 2018

Example of unneeded detail in the Bugfix section:

Since Let's Encrypt is a new feature, there's no point in listing fixes to bugs in its implementation
(there may be more like that)

@adelowo
Copy link
Member

adelowo commented Nov 22, 2018

Finally 💯 💯

@lunny
Copy link
Member Author

lunny commented Nov 23, 2018

@lafriks @strk done.

@techknowlogick techknowlogick merged commit 0da8bc9 into go-gitea:release/v1.6 Nov 23, 2018
@lunny lunny deleted the lunny/release_v1.6 branch November 23, 2018 06:27
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

@jonasfranz jonasfranz jonasfranz approved these changes

@adelowo adelowo adelowo approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
8 participants
@lunny @lafriks @strk @adelowo @appleboy @jonasfranz @techknowlogick @bkcsoft