Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable borders in all labels #5487

Closed
wants to merge 2 commits into from
Closed

Enable borders in all labels #5487

wants to merge 2 commits into from

Conversation

Monter
Copy link

@Monter Monter commented Dec 6, 2018

Enable borders in all labels

@Monter
Update index.css
107fa21 
Enable borders in all labels
@techknowlogick
Copy link
Member

techknowlogick commented Dec 6, 2018 •
edited
Loading

Please edit less file the run make generate-stylesheets, and provide screenshots.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 6, 2018
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Dec 6, 2018
@techknowlogick techknowlogick changed the title Update index.css Enable borders in all labels Dec 6, 2018
@Monter
Copy link
Author

Monter commented Dec 6, 2018

Before:
before

After:
after

@lunny lunny added this to the 1.7.0 milestone Dec 7, 2018
@techknowlogick techknowlogick modified the milestones: 1.7.0, 1.8.0 Dec 19, 2018
@silverwind
Copy link
Member

silverwind commented Feb 7, 2019 •
edited
Loading

Something's wrong here, your change only affects the .css file, but it should also be in .less. You should just edit the less file, run make generate-stylesheet and then commit both files.

@techknowlogick techknowlogick modified the milestones: 1.8.0, 1.9.0 Feb 19, 2019
@stale
Copy link

stale bot commented Apr 20, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 20, 2019
@lunny
Copy link
Member

lunny commented Apr 20, 2019

conflicted

@stale stale bot removed the issue/stale label Apr 20, 2019
@techknowlogick techknowlogick modified the milestones: 1.9.0, 1.10.0 Jun 4, 2019
@stale
Copy link

stale bot commented Aug 4, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 4, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Aug 4, 2019
@stale stale bot removed the issue/stale label Aug 4, 2019
@silverwind silverwind mentioned this pull request Aug 4, 2019
Merged
silverwind added a commit to silverwind/gitea that referenced this pull request Aug 4, 2019
@silverwind
Tweak label border CSS
1df27a4 
Also did various tweaks to label hover and dark theme.

Fixes: go-gitea#5487
@lunny lunny closed this Aug 4, 2019
lunny pushed a commit that referenced this pull request Aug 4, 2019
@silverwind @lunny
Tweak label border CSS (#7739)
a1f5789 
Also did various tweaks to label hover and dark theme.

Fixes: #5487
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Monter @techknowlogick @silverwind @lunny @bkcsoft