New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #5525 Fix the Let's Encrypt handler #5527

Merged
merged 1 commit into from Dec 11, 2018

Conversation

5 participants
@gregkare
Copy link
Contributor

gregkare commented Dec 11, 2018

  • Fix the Let's Encrypt handler by listening on a valid address

Also handle errors in the HTTP server go routine, return a fatal error
when something goes wrong.

Thanks to @gbl08ma for finding the actual bug

Here is an example of the error handling:

2018/12/11 14:23:07 [....io/gitea/cmd/web.go:87 func1()] [E] Failed to
start the Let's Encrypt handler on port 30: listen tcp 0.0.0.0:30: bind:
permission denied

Closes #5280

  • Fix a typo
Backported #5525 Fix the Let's Encrypt handler
* Fix the Let's Encrypt handler by listening on a valid address

Also handle errors in the HTTP server go routine, return a fatal error
when something goes wrong.

Thanks to @gbl08ma for finding the actual bug

Here is an example of the error handling:

    2018/12/11 14:23:07 [....io/gitea/cmd/web.go:87 func1()] [E] Failed to
    start the Let's Encrypt handler on port 30: listen tcp 0.0.0.0:30: bind:
    permission denied

Closes #5280

* Fix a typo

@bkcsoft bkcsoft added the lgtm/need 1 label Dec 11, 2018

@Bwko

Bwko approved these changes Dec 11, 2018

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Dec 11, 2018

@techknowlogick techknowlogick merged commit 716c291 into go-gitea:release/v1.6 Dec 11, 2018

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@lafriks lafriks added the kind/bug label Dec 11, 2018

@lafriks lafriks added this to the 1.6.2 milestone Dec 11, 2018

@gregkare gregkare deleted the 67P:release/v1.6 branch Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment