Fix failing migration v67

[KubqoA]

Fixes issue number #5848

[codecov-io]

Codecov Report

Merging #5849 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #5849      +/-   ##
==========================================
+ Coverage   37.86%   37.88%   +0.01%     
==========================================
  Files         328      328              
  Lines       48318    48318              
==========================================
+ Hits        18294    18303       +9     
+ Misses      27393    27387       -6     
+ Partials     2631     2628       -3

Impacted Files	Coverage Δ
models/migrations/v67.go	0% <0%> (ø)	⬆️
models/repo_indexer.go	48.3% <0%> (+3.81%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8510ac2...5704b21. Read the comment docs.

[zeripath]

The accessLevel function should also probably make its requests within the session too - although shouldn't deadlock.

There's a few other places in that file where X is used to perform queries within the transaction. I think we should probably just move those over too.

[zeripath]

https://github.com/KubqoA/gitea/blob/044cd806b0be8642e9ff51fe4994a8d4012d0ae3/models/migrations/v67.go#L133

Needs to also be in the sess

[KubqoA]

@zeripath I changed line 133 and line 63, which contained x.get to sess.get

[KubqoA]

Changing line 63 broke the build, so I reverted the change on that line.

[zeripath]

@KubqoA I took the liberty of fixing the remaining deadlocks. Unfortunately I guess that means that I can't really LGTM this anymore...

[KubqoA]

Thanks, so now we need to wait for someone else to LGTM this?

[zeripath]

Hmm. LGTM has set itself to done... So may be someone else has looked at it.

@KubqoA could you just check that this migration change actually works for you though.

[zeripath]

@KubqoA does it work?

[KubqoA]

How would I check if it works? I am running the docker version. Does it mean I need to create a custom Docker image and check it?

[zeripath]

OK I've just cherry-picked my migration test PR on top of this and it doesn't break the migration tests for v1.5.3 onwards so I'm going to say it works

[KubqoA]

Great! So soon I can upgrade to the latest build of the Docker image and it should work?

[KubqoA]

@zeripath can this get merged now?

[KubqoA]

You are an awesome person @zeripath, thanks to you, my Gitea instance is again up and running without any problems so far. I am very happy for the power of open-source project communities. Keep on going!