Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't allow pull requests to be created on an archived repository #5883

Merged
merged 5 commits into from
Jan 30, 2019
Merged

don't allow pull requests to be created on an archived repository #5883

merged 5 commits into from
Jan 30, 2019

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Jan 28, 2019 •
edited
Loading

This also disables the "PR" button if the repo is archived.

  • UI
  • API

@adelowo
don't allow pull requests to be created on an archived repository
eb02921 
Also disable the "PR" button if the repo is archived
@techknowlogick techknowlogick added this to the 1.8.0 milestone Jan 28, 2019
@techknowlogick techknowlogick added topic/ui Change the appearance of the Gitea UI type/bug labels Jan 28, 2019
@codecov-io
Copy link

codecov-io commented Jan 28, 2019 •
edited
Loading

Codecov Report

Merging #5883 into master will decrease coverage by <.01%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5883      +/-   ##
=========================================
- Coverage   38.01%     38%   -0.01%     
=========================================
  Files         328     328              
  Lines       48338   48343       +5     
=========================================
- Hits        18374   18373       -1     
- Misses      27325   27331       +6     
  Partials     2639    2639
Impacted Files Coverage Δ
routers/routes/routes.go 85.05% <100%> (ø) ⬆️
routers/api/v1/api.go 73.24% <60%> (-0.53%) ⬇️
models/unit.go 0% <0%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dc2f40...a491310. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 28, 2019
zeripath
zeripath reviewed Jan 28, 2019
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the API can create issues and pulls on archived repositories too.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 28, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 30, 2019
@techknowlogick
Copy link
Member

make LG-TM work

@techknowlogick techknowlogick merged commit 57a69ef into go-gitea:master Jan 30, 2019
@adelowo adelowo deleted the dont_allow_pr_creation_when_archived branch January 30, 2019 17:21
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
6 participants
@adelowo @codecov-io @techknowlogick @lunny @zeripath @GiteaBot