New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin config page mailertype setting option update #5973

Merged
merged 5 commits into from Feb 6, 2019

Conversation

6 participants
@techknowlogick
Copy link
Member

techknowlogick commented Feb 6, 2019

Fix #5972

@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 6, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 6, 2019

Codecov Report

Merging #5973 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5973      +/-   ##
==========================================
+ Coverage    38.7%   38.71%   +<.01%     
==========================================
  Files         330      330              
  Lines       48697    48697              
==========================================
+ Hits        18849    18853       +4     
+ Misses      27119    27114       -5     
- Partials     2729     2730       +1
Impacted Files Coverage Δ
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️
routers/repo/view.go 47.3% <0%> (+1.19%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c721fe...34ca473. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 label Feb 6, 2019

@lunny

lunny approved these changes Feb 6, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Feb 6, 2019

@zeripath
Copy link
Contributor

zeripath left a comment

Sorry!

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 6, 2019

techknowlogick added some commits Feb 6, 2019

Show resolved Hide resolved templates/admin/config.tmpl Outdated

@techknowlogick techknowlogick merged commit ad059fd into go-gitea:master Feb 6, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@techknowlogick techknowlogick deleted the techknowlogick:techknowlogick-patch-13 branch Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment