Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Issue attributes for API call #6122

Merged
merged 1 commit into from Feb 19, 2019

Conversation

@jolheiser
Copy link
Member

commented Feb 19, 2019

Fixes #6056

Issues were being loaded raw instead of with attributes. Changed the API to use the func that loads attributes.

issue api milestone

Load Issue attributes for API call
Signed-off-by: jolheiser <john.olheiser@gmail.com>

@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 19, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Feb 19, 2019

Codecov Report

Merging #6122 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6122      +/-   ##
==========================================
- Coverage   38.85%   38.84%   -0.02%     
==========================================
  Files         352      352              
  Lines       50030    50030              
==========================================
- Hits        19440    19434       -6     
- Misses      27776    27783       +7     
+ Partials     2814     2813       -1
Impacted Files Coverage Δ
routers/api/v1/repo/issue.go 23.46% <0%> (ø) ⬆️
models/unit.go 0% <0%> (-14.29%) ⬇️
routers/repo/view.go 44.54% <0%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 987a521...add7dd6. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 19, 2019

@lafriks lafriks merged commit ba0749b into go-gitea:master Feb 19, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
@sankethpb

This comment has been minimized.

Copy link

commented Feb 25, 2019

@lafriks Is there any workaround for this in 1.7.2?
Would be great to have it back ported to 1.7.3, thank you.

@lafriks

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

Please backport to 1.7

@jolheiser jolheiser deleted the jolheiser:6056_api_issue_milestone branch Feb 26, 2019

jolheiser added a commit to jolheiser/gitea that referenced this pull request Feb 26, 2019

Load Issue attributes for API call (go-gitea#6122)
Signed-off-by: jolheiser <john.olheiser@gmail.com>

techknowlogick added a commit that referenced this pull request Feb 26, 2019

Load Issue attributes for API call (#6122) (#6185)
Signed-off-by: jolheiser <john.olheiser@gmail.com>

Mikescher added a commit to Mikescher/gitea that referenced this pull request Mar 20, 2019

Load Issue attributes for API call (go-gitea#6122)
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
You can’t perform that action at this time.