fix dump table name error and add some test for dump database #6394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6394 +/- ##
=========================================
Coverage ? 38.86%
=========================================
Files ? 365
Lines ? 51389
Branches ? 0
=========================================
Hits ? 19971
Misses ? 28546
Partials ? 2872
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
|
Will add some dump integration tests after this merged. |
jolheiser
requested changes
Mar 20, 2019
models/models.go
Outdated
| x *xorm.Engine | ||
| tables []interface{} | ||
| x *xorm.Engine | ||
| supportedDatabse = []string{"mysql", "postgres", "mssql"} |
There was a problem hiding this comment.
Small typo nit, should be supportedDatabase or supportedDatabases and refactored as needed where used.
There was a problem hiding this comment.
done. It's strange that misspell check failed.
jolheiser
approved these changes
Mar 20, 2019
GiteaBot
added
lgtm/need 1
sapk
approved these changes
Mar 20, 2019
GiteaBot
added
lgtm/done
axifive
approved these changes
Mar 20, 2019
|
but need to run fmt |
|
@lunny merged. Please backport 😄 |
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Mar 21, 2019
zeripath
pushed a commit
that referenced
this pull request
Mar 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix #6310 and replace #6385