routers/repo/setting: display correct error for invalid mirror interval #6414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set Err_Interval in the context data so that the mirror interval box is highlighted red as expected. Clear Err_RepoName for the mirror and advanced actions. repo_name is not set by these forms, causing auth.validate() to set the Err_RepoName before SettingsPost is called, which would lead to the repository name box getting erroneously highlighted red. Fixes: go-gitea#6396
aswild
force-pushed
the
pr-mirror-interval-err
branch
from
fdd895c
to
954863f
Compare
Codecov Report
@@ Coverage Diff @@
## master #6414 +/- ##
=========================================
Coverage ? 38.86%
=========================================
Files ? 365
Lines ? 51401
Branches ? 0
=========================================
Hits ? 19978
Misses ? 28554
Partials ? 2869
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lafriks
approved these changes
Mar 24, 2019
GiteaBot
added
lgtm/need 1
jolheiser
approved these changes
Mar 25, 2019
GiteaBot
added
lgtm/done
|
Thanks for PR @aswild 😃 Please send a backport to release/v1.8 branch with these changes. If you need any assistance please don't hesitate to ask. |
|
Cherry-picked (cleanly) to v1.8: #6429 |
techknowlogick
added
the
backport/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set Err_Interval in the context data so that the mirror interval box is
highlighted red as expected.
Clear Err_RepoName for the mirror and advanced actions. repo_name is not
set by these forms, causing auth.validate() to set the Err_RepoName
before SettingsPost is called, which would lead to the repository name
box getting erroneously highlighted red.
Fixes: #6396