Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unitTypeCode not being used in accessLevelUnit #6419

Merged
merged 1 commit into from Mar 24, 2019

Conversation

@kolaente
Copy link
Member

commented Mar 24, 2019

While doing some refactoring for #6418 I discovered this function was essentially useless.

@lunny

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

@kolaente also find HasAccessUnit is not used any more. Maybe we could remove it.

@lunny lunny added the kind/bug label Mar 24, 2019

@lunny

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

Since canBeAssigned referenced hasAccessUnit and it in fact gave unitType as UnitTypeCode. This haven't really taken an effect.

@lunny lunny added this to the 1.9.0 milestone Mar 24, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Mar 24, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@b48be19). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6419   +/-   ##
=========================================
  Coverage          ?   38.87%           
=========================================
  Files             ?      365           
  Lines             ?    51393           
  Branches          ?        0           
=========================================
  Hits              ?    19979           
  Misses            ?    28547           
  Partials          ?     2867
Impacted Files Coverage Δ
models/repo_permission.go 72.02% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48be19...ac09e74. Read the comment docs.

@kolaente

This comment has been minimized.

Copy link
Member Author

commented Mar 24, 2019

Since canBeAssigned referenced hasAccessUnit and it in fact gave unitType as UnitTypeCode. This haven't really taken an effect.

Sure, but I'd do that in #6418 as there are a lot other unused functions as well which I removed in that pr also.

@lunny

lunny approved these changes Mar 24, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Mar 24, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Mar 24, 2019

@lafriks lafriks merged commit fb2ea06 into go-gitea:master Mar 24, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
@kolaente

This comment has been minimized.

Copy link
Member Author

commented Mar 24, 2019

Should I send a backport?

@lafriks

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

I think yes

zeripath added a commit that referenced this pull request Mar 24, 2019

@kolaente kolaente deleted the kolaente:fix/access-level-unit branch Mar 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.