Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong GPG expire date #6643

Merged
merged 2 commits into from Apr 16, 2019

Conversation

5 participants
@sapk
Copy link
Member

commented Apr 15, 2019

Fix #6599

The expire date of key is calculated relative to creation time of the key not the sig. https://tools.ietf.org/html/rfc4880#section-5.2.3.6

@techknowlogick
Copy link
Member

left a comment

Thanks 😄

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Apr 15, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 15, 2019

Codecov Report

Merging #6643 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6643      +/-   ##
==========================================
+ Coverage   40.53%   40.54%   +<.01%     
==========================================
  Files         406      406              
  Lines       54494    54498       +4     
==========================================
+ Hits        22088    22094       +6     
+ Misses      29370    29368       -2     
  Partials     3036     3036
Impacted Files Coverage Δ
models/gpg_key.go 53.88% <100%> (+0.51%) ⬆️
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️
routers/repo/view.go 42.07% <0%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecfa5f1...e83dddb. Read the comment docs.

@techknowlogick techknowlogick merged commit e98565d into go-gitea:master Apr 16, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

lunny added a commit that referenced this pull request Apr 16, 2019

@sapk sapk deleted the sapk-fork:fix-6599 branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.