Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong GPG expire date #6643

Merged
merged 2 commits into from
Apr 16, 2019
Merged

Fix wrong GPG expire date #6643

merged 2 commits into from
Apr 16, 2019

Conversation

sapk
Copy link
Member

@sapk sapk commented Apr 15, 2019

Fix #6599

The expire date of key is calculated relative to creation time of the key not the sig. https://tools.ietf.org/html/rfc4880#section-5.2.3.6

@techknowlogick techknowlogick added this to the 1.9.0 milestone Apr 15, 2019
techknowlogick
techknowlogick approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😄

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 15, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 15, 2019
@codecov-io
Copy link

codecov-io commented Apr 15, 2019 •
edited
Loading

Codecov Report

Merging #6643 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6643      +/-   ##
==========================================
+ Coverage   40.53%   40.54%   +<.01%     
==========================================
  Files         406      406              
  Lines       54494    54498       +4     
==========================================
+ Hits        22088    22094       +6     
+ Misses      29370    29368       -2     
  Partials     3036     3036
Impacted Files Coverage Δ
models/gpg_key.go 53.88% <100%> (+0.51%) ⬆️
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️
routers/repo/view.go 42.07% <0%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecfa5f1...e83dddb. Read the comment docs.

@sapk sapk mentioned this pull request Apr 16, 2019
Merged
@techknowlogick techknowlogick merged commit e98565d into go-gitea:master Apr 16, 2019
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Apr 16, 2019
lunny pushed a commit that referenced this pull request Apr 16, 2019
@sapk @lunny
[backport] Fix wrong GPG expire date (#6643) (#6644)
f43783f 
* fix expire of gpg relative to key creation https://tools.ietf.org/html/rfc4880#section-5.2.3.6

* add test
@sapk sapk deleted the fix-6599 branch April 16, 2019 11:40
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Expiry date of GPG key is reported wrong
5 participants
@sapk @codecov-io @techknowlogick @mrsdizzie @GiteaBot