Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure to read interval value when making use of redis or memcache #6770

Closed
wants to merge 1 commit into from
Closed

make sure to read interval value when making use of redis or memcache #6770

wants to merge 1 commit into from

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Apr 26, 2019 •
edited

Fixes #6730

This is a UI fix, see #6861

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 26, 2019
@lafriks lafriks added this to the 1.9.0 milestone Apr 26, 2019
@codecov-io
Copy link

Codecov Report

Merging #6770 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6770      +/-   ##
==========================================
- Coverage   40.99%   40.99%   -0.01%     
==========================================
  Files         421      421              
  Lines       58054    58055       +1     
==========================================
- Hits        23802    23799       -3     
- Misses      31086    31090       +4     
  Partials     3166     3166
Impacted Files Coverage Δ
modules/setting/cache.go 75% <100%> (+1.66%) ⬆️
modules/log/router.go 90% <0%> (-2.5%) ⬇️
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81059a2...eae444c. Read the comment docs.

@adelowo adelowo changed the title make sure to read interval value when making usee of redis or memcache make sure to read interval value when making use of redis or memcache Apr 26, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 27, 2019
lunny
lunny requested changes Apr 27, 2019
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems Interval is for memory but TTL is for redis?

@adelowo
Copy link
Member Author

adelowo commented Apr 27, 2019 •
edited

@lunny Hmm, so a better solution is to revert these changes and update the UI based on what cache provider is being used? Show TTL if memcached or Redis but interval if memory ?

@lunny lunny mentioned this pull request May 6, 2019
Merged
@adelowo adelowo closed this May 6, 2019
@adelowo adelowo deleted the fix_redis_memcache_ttl_not_being_read_from_config branch May 6, 2019 12:44
@techknowlogick techknowlogick removed this from the 1.9.0 milestone May 6, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny requested changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redis cache configuration always got Cache Interval 0 seconds
6 participants
@adelowo @codecov-io @lunny @lafriks @techknowlogick @GiteaBot