Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor table width to have more info shown in file list #6867

Merged
merged 4 commits into from
May 6, 2019
Merged

Refactor table width to have more info shown in file list #6867

merged 4 commits into from
May 6, 2019

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented May 6, 2019

Fixes #5529

Old:
attels

New:
attels

@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label May 6, 2019
@lafriks lafriks added this to the 1.9.0 milestone May 6, 2019
@lafriks
Copy link
Member Author

lafriks commented May 6, 2019 •
edited
Loading

Sorry for .less file reformat, it was quite messy :)

Relevant changes here:
https://github.com/go-gitea/gitea/pull/6867/files#diff-4c18d74f0d0687b8503915779673f3ebR303

and here: https://github.com/go-gitea/gitea/pull/6867/files#diff-4c18d74f0d0687b8503915779673f3ebL241

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 6, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 6, 2019
@zeripath
Copy link
Contributor

zeripath commented May 6, 2019

That's a remarkably simple fix!

@lafriks lafriks added the type/enhancement An improvement of existing functionality label May 6, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 6, 2019
@codecov-io
Copy link

Codecov Report

Merging #6867 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6867      +/-   ##
==========================================
- Coverage   41.19%   41.17%   -0.02%     
==========================================
  Files         425      425              
  Lines       58490    58490              
==========================================
- Hits        24094    24085       -9     
- Misses      31209    31219      +10     
+ Partials     3187     3186       -1
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️
routers/repo/view.go 42.02% <0%> (-1.02%) ⬇️
models/gpg_key.go 55.83% <0%> (-0.84%) ⬇️
modules/log/file.go 77.62% <0%> (+2.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ebd52...6befc46. Read the comment docs.

@lafriks lafriks merged commit d9d538c into go-gitea:master May 6, 2019
@lafriks lafriks deleted the fix/file_browser_width branch May 6, 2019 18:43
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@adelowo adelowo adelowo approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

File names truncated in table view
5 participants
@lafriks @zeripath @codecov-io @adelowo @GiteaBot