Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix U2F for Chrome >= 74 #6980

Merged
merged 1 commit into from May 18, 2019

Conversation

@daviian
Copy link
Member

commented May 18, 2019

Resolves #6748

@daviian daviian changed the title Fix U2F for Chrome > 74 Fix U2F for Chrome >= 74 May 18, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 18, 2019

Codecov Report

Merging #6980 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6980      +/-   ##
==========================================
- Coverage   41.44%   41.43%   -0.01%     
==========================================
  Files         441      441              
  Lines       59696    59696              
==========================================
- Hits        24742    24737       -5     
- Misses      31729    31735       +6     
+ Partials     3225     3224       -1
Impacted Files Coverage Δ
models/u2f.go 63.15% <0%> (ø) ⬆️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
modules/git/git.go 33.33% <0%> (-5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c385dcc...6974d40. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels May 18, 2019

@lafriks lafriks added this to the 1.9.0 milestone May 18, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels May 18, 2019

@zeripath
Copy link
Contributor

left a comment

D'oh

@zeripath zeripath merged commit 8de76b6 into go-gitea:master May 18, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@zeripath

This comment has been minimized.

Copy link
Contributor

commented May 18, 2019

Please send backport

daviian added a commit to daviian/gitea that referenced this pull request May 18, 2019

@daviian daviian deleted the daviian:fix/u2f-chrome74 branch May 18, 2019

techknowlogick added a commit that referenced this pull request May 18, 2019

jeffliu27 added a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.