Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable arm7 builds #7037

Merged
merged 2 commits into from
May 25, 2019
Merged

Disable arm7 builds #7037

merged 2 commits into from
May 25, 2019

Conversation

techknowlogick
Copy link
Member

As arm6 works on arm7 platforms with no noticeable performance difference

As arm6 works on arm7 platforms with no noticeable performance difference
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a pity we're not able to work this one out. Hopefully we'll be able to fix this in future.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 25, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 25, 2019
@lafriks lafriks merged commit a83c80a into master May 25, 2019
@lafriks lafriks deleted the techknowlogick-patch-1 branch May 25, 2019 08:38
@lafriks
Copy link
Member

lafriks commented May 25, 2019

Please send backport

@Beluk
Copy link

Beluk commented May 25, 2019

Without arm7 i am not able to run it on my Synology anymore with a newer Version :-(

@zeripath
Copy link
Contributor

does arm6 not work for you?

@Beluk
Copy link

Beluk commented May 25, 2019

Unfortunately not. Tried to build a new package for my Synology with this package:
https://github.com/flipswitchingmonkey/gitea-spk
I was always fine with arm7, but with one of the last version arm7 did not work anymore. I read about arm6 would being an alternative. I tried it with the script. First it did not accept. I changed the build script to accept also arm6. But on my Synology it did not start. Not sure what the problem is exactly but i gave up after several hours of try and hoped it will be solved in one of the future releases of gitea.

The german guides i used for Synology running Gitea are:
https://www.ipod-infos.de/gitea-auf-einer-synology-ds918-installieren/
https://canox.net/2017/12/gitea-auf-einer-synology-diskstation/

@techknowlogick
Copy link
Member Author

techknowlogick commented May 25, 2019

Edit: read your latest message. Please ignore this question

@Beluk
Copy link

Beluk commented May 25, 2019

The last one i tried was:
https://github.com/go-gitea/gitea/releases/download/v1.8.0/gitea-1.8.0-linux-arm-7
and this one did not worked. Did you change something on 1.8.1?

techknowlogick added a commit that referenced this pull request May 25, 2019
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label May 25, 2019
@zeripath
Copy link
Contributor

@Beluk yeah there's been a problem with our static arm7 builds that has forced us to have to stop providing them. If you're able to cross-compile non-static arm7 builds do work.

@Beluk
Copy link

Beluk commented May 25, 2019

Thanks for the hint. I will give it a try...

zeripath pushed a commit that referenced this pull request May 25, 2019
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
* Disable arm7 builds

As arm6 works on arm7 platforms with no noticeable performance difference

* 386
flipswitchingmonkey added a commit to flipswitchingmonkey/gitea-spk that referenced this pull request Jul 20, 2019
@IzzySoft
Copy link

Will arm7 support return, or is this final?

@lunny
Copy link
Member

lunny commented Jul 31, 2019

It will return. This is a temporary disable.

@IzzySoft
Copy link

Thanks, @lunny! Besides: The last two available ARMv7 (1.8.0 and 1.8.1) seem broken as well (which of course could be "only me"). The latest one working for me is 1.7.5. But indeed, the ARMv6 binaries do work on my BananaPi, so until working ARMv7 return I'll stick to those (currently running v1.8.3 that way).

@juliangaal
Copy link

binaries do work on my BananaPi, so until working ARMv7 return I'll stick to those (currently running v1.8.3 that way).

Are you using docker for that?

Is there a way to force the docker image to use armv6, until armv7 is officially supported again?

@IzzySoft
Copy link

@funkythings why should I use docker to run a simple binary? No, the BananaPi is running Armbian, and I simply drop in the binary. I've never worked with docker, to be honest.

@juliangaal
Copy link

once you have multiple services running with docker already, one more doesn't hurt.

@techknowlogick
Copy link
Member Author

This PR is in regards to the binaries, not the docker container. For general discussion please don't use PRs as hundreds of people get these emails.

@go-gitea go-gitea locked and limited conversation to collaborators Mar 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants