API error cleanup #7186
Merged
API error cleanup #7186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced DocURL with SwaggerURL Added error for fork already existing Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
jolheiser
commented
Jun 12, 2019
| @@ -580,17 +582,17 @@ func NewContext() { | |||
| AppURL = strings.TrimRight(AppURL, "/") + "/" | |||
|
|
|||
| // Check if has app suburl. | |||
| url, err := url.Parse(AppURL) | |||
| appURL, err := url.Parse(AppURL) | |||
There was a problem hiding this comment.
Changed url to appURL because url collides with the Go url package, and also to clarify the variable for use down below
GiteaBot
added
the
lgtm/need 2
jolheiser
commented
Jun 12, 2019
| @@ -899,6 +901,10 @@ func NewContext() { | |||
| log.Fatal("Failed to map Metrics settings: %v", err) | |||
| } | |||
|
|
|||
| u := *appURL | |||
There was a problem hiding this comment.
De-referenced the pointer in case anyone uses appURL in a later change, since right below this I fudge the u.Path manually.
Signed-off-by: jolheiser <john.olheiser@gmail.com>
lunny
approved these changes
Jun 12, 2019
GiteaBot
added
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #7186 +/- ##
==========================================
+ Coverage 41.72% 41.73% +<.01%
==========================================
Files 449 449
Lines 61129 61127 -2
==========================================
+ Hits 25506 25511 +5
+ Misses 32310 32302 -8
- Partials 3313 3314 +1
Continue to review full report at Codecov.
|
zeripath
approved these changes
Jun 12, 2019
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed
base.DocURLcompletely because it shows up in Swagger errors and doesn't necessarily help with said errors.It is a valuable link for users who create clients to interact with the Gitea API, however in the context of Swagger it's not entirely helpful in my opinion.
This PR adds
settings.API.SwaggerURLwhich is simply the path to a given instance's base Swagger page and is used in any API error.