Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7736: remove -i flag from GOFLAGS #7778

Merged
merged 1 commit into from Aug 7, 2019
Merged

Conversation

Sr4l
Copy link
Contributor

@Sr4l Sr4l commented Aug 7, 2019

Fix #7736: this flag is not needed for Go versions >=1.10 and creates problems
while building. see golang/go#27285 (comment)

this flag is not needed for Go versions >=1.10 and creates problems
while building. see golang/go#27285 (comment)
Copy link
Member

@sapk sapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contrib.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 7, 2019
@lafriks lafriks added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Aug 7, 2019
@lafriks lafriks added this to the 1.10.0 milestone Aug 7, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 7, 2019
@codecov-io
Copy link

Codecov Report

Merging #7778 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7778      +/-   ##
==========================================
+ Coverage    41.3%   41.31%   +<.01%     
==========================================
  Files         474      474              
  Lines       63837    63837              
==========================================
+ Hits        26371    26377       +6     
+ Misses      34028    34021       -7     
- Partials     3438     3439       +1
Impacted Files Coverage Δ
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️
routers/repo/view.go 43.25% <0%> (+1.01%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c832f0e...fb2f71a. Read the comment docs.

@lunny lunny merged commit 714dcf9 into go-gitea:master Aug 7, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure on i386 for v1.9
6 participants